Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent clients. #2639

Open
DailyDreaming opened this issue Nov 27, 2019 · 1 comment
Open

Consistent clients. #2639

DailyDreaming opened this issue Nov 27, 2019 · 1 comment

Comments

@DailyDreaming
Copy link
Contributor

We seem to have a mix of clients imported from either the dss or dcplib. We should probably consolidate and use one set.

For example both:

from dcplib.aws.clients import logs

or

from dss.util.aws.clients import dynamodb as db

...are used in the DSS and we should probably import all of our clients from only one.

@chmreid
Copy link
Contributor

chmreid commented Nov 27, 2019

While we're at it, we should probably check for boto3 clients too:

import boto3

client = boto3.client('dynamodb')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants