Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup DOM nodes on destroy #43

Open
baptistebriel opened this issue Jan 19, 2016 · 0 comments
Open

cleanup DOM nodes on destroy #43

baptistebriel opened this issue Jan 19, 2016 · 0 comments

Comments

@baptistebriel
Copy link

Hello,

First of all, thanks for the plugin! I'm working on a SPA will lots of custom <select> elements and came across a few issues... Related to #23, I'll bring some more details here hoping that it will get fixed soon.

My biggest issue is that after navigating through the website, the previously used selects aren't removed from the DOM. I also noticed there was a few addEventListener using anonymous functions; using a named function would allow us to call the removeEventListener after that. This would help with GC & memory leaks.

screen shot 2016-01-19 at 14 22 37

Pretty long list, right? And my computer screen wasn't long enough 😅

Also, all of theses nodes have a transform property applied; that will create a new GraphicsLayer for each one of them, which could be quite dangerous..

Let me know if I can help in any way, I'd be happy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant