Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging will be broken by dart-lang/logging#71 #6

Open
jamesderlin opened this issue Jan 16, 2020 · 0 comments
Open

Logging will be broken by dart-lang/logging#71 #6

jamesderlin opened this issue Jan 16, 2020 · 0 comments

Comments

@jamesderlin
Copy link

I've recently made a change (dart-lang/logging#71) that affects the behavior of Logger.detached from package:logging. This change expected to be included in logging 0.11.4.

This change in behavior should not affect most packages, but it appears that it will break logging in the s3_cache_image package.

The recommended fix is to set Logger.level and Logger.onRecord on the detached Logger itself instead of on Logger.root. (In general, libraries should leave responsibility for configuring Logger.root to the application.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant