Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "enable" everywhere #118

Open
svaningelgem opened this issue Aug 13, 2024 · 2 comments
Open

Add "enable" everywhere #118

svaningelgem opened this issue Aug 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@svaningelgem
Copy link
Contributor

I'm a bit shy to propose this one, but as a first-timer to this plugin, it gets quite confusing...

For example to turn things off (educated guesses):
animals: chance: 0
structures: (mostly) enabled: false
however: villages should probably be spawnratio: 0.0
biome: weight: 0
But biome.cave: maxsize: 0
ores: chance-per-chunk: 0.0
trees: enabled: false

You get what I mean 😉? Every option is logical, but it'd be nice if they are harmonized... Or simplified by an "enabled" everywhere?

@Hex27
Copy link
Owner

Hex27 commented Sep 26, 2024

Is this considered done?

@svaningelgem
Copy link
Contributor Author

Hi @Hex27 , as a new user of this plugin, I found the various methods to disable features confusing. Different features use inconsistent settings to turn them off. (see what I figured out above)

While each option is logical, it would be beneficial to harmonize these settings.

The enable I've implemented just turns them off/on, but it doesn't address the underlying issue I pointed out in this ticket.

Of course feel free to close it, but I still think this one has merit enough to be addressed.

@Hex27 Hex27 added the enhancement New feature or request label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants