-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pause
does not unregister handlers
#73
Labels
Comments
That's a good point, thanks! I will only fix the documentation for now, but I will address the issue in a future version. |
HeinrichApfelmus
added a commit
that referenced
this issue
Dec 21, 2014
…re not, in fact, unregistered. #73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation of
pause
saysBut the code doesn't unregister anything, it just sets a flag to ignore input.
This means, that the lifetime of a network depends on the lifetime of any
AddHandler
it is registered with.For example, the memory usage of the following program will grow linearly, because
addHandler
keeps a reference to every network:Maybe having a
dispose
function would be a good idea? Or use a weak reference for registered handlers?The text was updated successfully, but these errors were encountered: