Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect person file #11

Open
2 of 6 tasks
anwarfg opened this issue Jan 10, 2025 · 0 comments
Open
2 of 6 tasks

Automatically detect person file #11

anwarfg opened this issue Jan 10, 2025 · 0 comments

Comments

@anwarfg
Copy link

anwarfg commented Jan 10, 2025

Is this the right issue type?

  • Yes, I'm planning work for this project team.

Summary

The person file argument can be removed (set as an optional arg) and automatically detected since it is defined as the file with the person_id as the first column.

This could be as simple as opening all the input files, reading the header and checking the first entry until we find person_id. It would be more complete if we check all files, as it'd be ambiguous and should throw an error if there are multiple.

Fewer required args make it easier to run.

Acceptance Criteria

  • person-file is an optional argument.

  • person-file can be detected by checking files in the input dir.

  • Tests pass.

  • Documentation added.

Confirm creation

  • This issue is ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant