Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freezes with notes on piles #2952

Open
fpvandoorn opened this issue Jul 11, 2024 · 1 comment
Open

freezes with notes on piles #2952

fpvandoorn opened this issue Jul 11, 2024 · 1 comment

Comments

@fpvandoorn
Copy link
Contributor

fpvandoorn commented Jul 11, 2024

Describe the bug
The last two games I played were both Throw it in a Hole where both players wrote various notes on the decks:
https://hanab.live/replay/1198677#1
https://hanab.live/replay/1215257#1
In the first game lord_farin and in the second game florrat2 had issues with the browser freezing.

  • This seems to be a rendering issue, and in the second game, I had slowness for a while, but after waiting multiple seconds (and sometimes ignoring the warning that the tab was slow) it would continue in Firefox.
  • The issue occurred on all of Chrome, Firefox and even Edge.
  • When opening a new tab to get into the game, the background would be drawn, but none of the cards, and then the tab would freeze (not respond to F5 or any interaction in-game)
  • The issue does not occur when observing the game as spectator, or when re-entering as a player after the game was terminated.
  • Therefore it is probably a rendering issue related to the written notes on cards (anecdotally: lord_farin reported a lot better performance in the second game with very short notes on the piles).

Possible dupe of #2829, not sure what that issue means.

@WillFlame14
Copy link

RandomGuyJCI and I also encountered very similar symptoms in our last 2 games:
https://hanab.live/replay/1267413
https://hanab.live/replay/1267447

RandomGuyJCI froze in the first game and WillFlame froze in the second game. The second game was completed by connecting to hanab.live from the command line and sending actions manually, indicating that it was a client issue and not a server issue.

Similarly to above, pressing the refresh button did nothing and waiting for a few minutes produced no results. Opening a new tab and connecting to hanab.live joined the room and drew the background before freezing. RandP was able to join the second game as a spectator, but attempting to spectate as WillFlame also caused a freeze. In both games, the non-frozen player was able to perform actions as normal, though with a bit of lag. Once the game had ended, both players had no problems rejoining or taking actions.

RandomGuyJCI did a performance profile in the 2nd game while we were stuck and discovered that a significant amount of time was spent in cardDeductionReducer's possibilityValid(), but we don't really know what's happening. If it's related to hypo/empathy, perhaps that could be disabled or reduced for TIIAH games?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants