Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Dragging Bug #2950

Open
downvoid opened this issue Jun 21, 2024 · 1 comment
Open

Card Dragging Bug #2950

downvoid opened this issue Jun 21, 2024 · 1 comment

Comments

@downvoid
Copy link

Describe the bug
Sometimes, when you play a card, the game lags for a second and plays the card and then an error message pops up. There are 2 possible outcomes.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on pre-playing cards (I don't know if this is required for the bug to happen but it's pretty likely)
  2. Wait until a few seconds before your turn, then pick up a card from your hand
  3. it becomes your turn while the card is still being dragged
  4. play the card
  5. The game will lag, and one of two messages will pop up: either an error, or a warning saying "it is not your turn"

Expected behavior
A clear and concise description of what you expected to happen.
The card should play normally without any errors. Also, if pre playing cards is enabled, the "it is not your turn" message should never show up

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
This bug only happens once in about every 20-30 games. I don't know if these two messages popping up are related, or not, but the error message is just a generic error message that has a stack trace with a bunch of random 1 or 2 letter function names

@lancehc
Copy link
Contributor

lancehc commented Jul 21, 2024

I tried to reproduce this locally, but couldn't get it to happen. What I did:

  • comment out the lines in websocketInit.ts that validate the url (currently lines 14-18)(without this, it doesn't like that my other device isn't using a "localhost" url)
  • Turn on preplays
  • Connect with another device, also turnon preplays there
  • enter a game with both
  • drag a card like I'm going to play it, holding it there while I take an action on the other device

This worked smoothly every way I tried it, including swapping the roles of the two devices. My two devices were chrome on windows and chrome on android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants