Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add consistency in variable naming #7

Open
iMartzen opened this issue Jun 17, 2024 · 0 comments
Open

[BUG] Add consistency in variable naming #7

iMartzen opened this issue Jun 17, 2024 · 0 comments

Comments

@iMartzen
Copy link
Member

#Describe the bug

This codebase mixes python's standard snake_case style with camelCase and lowercase styles.
It's not uncommon to preserve the casing of variables from an external API:

productArea = pO['productArea']

but for variables like pageNum that are only being used in python, it's best to stick to camel_case like page_num. This will make reading and searching the code easier for python engineers.

🔹 Style Consistency (Nice to have)

See MR comment: https://github.com/Hacker0x01/hai-on-hackerone/pull/1/files#r1638472023

#To Reproduce
N/A

#Expected behavior
N/A

@iMartzen iMartzen changed the title Add consistency in variable naming [ BUG ] Add consistency in variable naming Jun 18, 2024
@iMartzen iMartzen changed the title [ BUG ] Add consistency in variable naming [BUG] Add consistency in variable naming Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant