Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example configuration in README.md #11

Closed
mark-strasser-nnl opened this issue May 10, 2024 · 1 comment · Fixed by #12
Closed

Fix example configuration in README.md #11

mark-strasser-nnl opened this issue May 10, 2024 · 1 comment · Fixed by #12

Comments

@mark-strasser-nnl
Copy link

The example configuration file (host param) in README.md is incorrect and causes the server to abort on startup.

host = "localhost"

Behavior

Aborts with error on startup.

Expected behavior

Server should start normally with the example configuration.

Error message

julia --project bin/run_server.jl ../localpackageserver-configs/config.toml
┌ Info: server listening on localhost:8000
└ Dates.now() = 2024-05-10T17:09:50.356
ERROR: LoadError: ArgumentError: invalid base 10 digit 'l' in "localhost"

Suggested fix

Update the example in README.md to state host = "127.0.0.1".

@mark-strasser-nnl mark-strasser-nnl changed the title Fix example in README.md Fix example configuration in README.md May 10, 2024
@GunnarFarneback
Copy link
Owner

Thanks for the report. Fixed in #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants