Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore invalid characters #24

Open
AlexeyTipunin opened this issue Aug 30, 2016 · 9 comments
Open

ignore invalid characters #24

AlexeyTipunin opened this issue Aug 30, 2016 · 9 comments

Comments

@AlexeyTipunin
Copy link

Hello.
Is it possible to ignore when entering invalid characters?

@JohanLarsson
Copy link
Member

JohanLarsson commented Aug 30, 2016

Do you mean ignoring as in detecting that user types in a letter and not update the text in the numeric box with it?

If so, no, there is currently no support for this. Not sure it is a nice user experience to type in things that gets removed.

Same with swapping out decimal separator ',' -> '.', no support for it.

@AlexeyTipunin
Copy link
Author

Too bad, sometimes it's a good way to protect against typing errors users are not getting along with your computer. Some users have problems with the use of a decimal point, too, would not be bad to have such a setting.

@JohanLarsson
Copy link
Member

JohanLarsson commented Aug 30, 2016

Are you interested in writing a PR for this? If so what would the API look like?
Maybe a property ValidInput="[0-9]\."?
Also we should probably notify via an event when we filter out input so that there is a way to notify user about what happened.

@JohanLarsson
Copy link
Member

Side note: Have you seen the ValidationTrigger property? Setting it to PropertyChanged will give the user immediate feedback if validation fails.

@AlexeyTipunin
Copy link
Author

The problem with this behavior is that despite the fact that the control signals in the model opishibke left recently successfully entered value with whom he continues to run the program.

If you add the property "allow incorrect input", which is a value of true ignorirovalaby entries, otherwise the behavior is left as it is, it is now.

I am interested in using this library, I have a similar, but your gorazdno soschnee and has almost everything you need, and even more)

@crosscourt
Copy link

I think its a good idea to prevent invalid characters.
This is how most numeric inputs work.

@JohanLarsson
Copy link
Member

What do we want the API to look like? We can spec things here in case someone writes a PR.

@crosscourt
Copy link

since it is a numeric input, it should be the default.
but at least u can have a property like NumericOnly=true
it should also not allow more than one dot '.'

@mgnslndh
Copy link

mgnslndh commented Jul 2, 2018

I am also interested in using this library and I would like a setting that only accepts numeric input.

I've done something similar before and did not use RegEx pattern. Instead I checked each new key press if the resulting string would be parsable (TryParse) using the actual type (int, double, etc). The display value in the text box was formatted according to the current culture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants