Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge support #53

Open
PeterShaws opened this issue Mar 12, 2022 · 10 comments
Open

Badge support #53

PeterShaws opened this issue Mar 12, 2022 · 10 comments

Comments

@PeterShaws
Copy link

It would be nice not to lose the information from the Activity Bar badges. One possible implementation could look like the mockup below:

Activitus Bar with badges

Would that be feasible?

@PeterShaws
Copy link
Author

I just saw the wontfix on issue #37. Is that still the case?

@Gruntfuggly
Copy link
Owner

If you set activitusbar.showSourceControlCounter to true, it should show a number for the SCM view, but the others are not possible to do.

@PeterShaws
Copy link
Author

That's unfortunate. I did find and enable that option, but the counter didn't appear, even after reloading the window.

@Gruntfuggly
Copy link
Owner

Could you have look in the developer tool console (Help->Toggle Developer Tools) and see if there are any errors present?

@PeterShaws
Copy link
Author

PeterShaws commented Mar 17, 2022

Indeed there are:

log.ts:313   ERR [Extension Host] The system cannot find the path specified.
console.ts:137 [Extension Host] The system cannot find the path specified.
localProcessExtensionHost.ts:294 Extension Host
localProcessExtensionHost.ts:295 The system cannot find the path specified.

@Gruntfuggly
Copy link
Owner

Hmm. Unfortunately that doesn't give me much to go on - was there anything else?

@PeterShaws
Copy link
Author

PeterShaws commented Mar 20, 2022

Yeah, I thought the same, but I can't make heads or tails of the trace for the ExtensionHost error:

[Extension Host] The system cannot find the path specified.
I @ console.ts:137
$logExtensionHostMessage @ mainThreadConsole.ts:39
_doInvokeHandler @ rpcProtocol.ts:473
_invokeHandler @ rpcProtocol.ts:458
_receiveRequest @ rpcProtocol.ts:374
_receiveOneMessage @ rpcProtocol.ts:296
(anonymous) @ rpcProtocol.ts:161
invoke @ event.ts:569
fire @ event.ts:736
fire @ ipc.net.ts:638
_receiveMessage @ ipc.net.ts:958
(anonymous) @ ipc.net.ts:831
invoke @ event.ts:569
fire @ event.ts:736
acceptChunk @ ipc.net.ts:382
(anonymous) @ ipc.net.ts:338
B @ ipc.net.ts:60
emit @ events.js:315
addChunk @ internal/streams/readable.js:309
readableAddChunk @ internal/streams/readable.js:284
Readable.push @ internal/streams/readable.js:223
onStreamRead @ internal/stream_base_commons.js:188

@cenidj
Copy link

cenidj commented Apr 6, 2022

Hey, I'm having the same problem.

The SCM badge in Linux works perfectly, but in Windows, it doesn't; In the Developer Tools it throws the error

The system cannot find the path specified.

I think the problem could be in the folder.uri.fsPath

var gitFolder = childProcess.execSync( 'git -C ' + folder.uri.fsPath + ' rev-parse --show-toplevel 2>/dev/null' ).toString();

@mikebronner
Copy link

mikebronner commented Apr 30, 2023

I'm not seeing the "SCM changes" badge either, this is on macOS Ventura, also don't see any errors in the developer console. Here are my settings:

    "activitusbar.combineWorkspaceSettings": true,
    "activitusbar.searchViewInPanel": false,
    "activitusbar.showSourceControlCounter": true,
    "activitusbar.views": [
        {
            "name": "explorer",
            "codicon": "explorer-view-icon"
        },
        {
            "name": "search",
            "codicon": "search-view-icon"
        },
        {
            "name": "pr:github",
            "codicon": "github"
        },
        {
            "name": "scm",
            "codicon": "source-control-view-icon"
        },
        {
            "name": "debug",
            "codicon": "run-view-icon"
        },
        {
            "name": "github.codespaces.explorer",
            "codicon": "remote-explorer"
        },
        {
            "name": "gitlens.views.home",
            "codicon": "git-merge"
        },
        {
            "name": "extensions",
            "codicon": "extensions-view-icon"
        },
        {
            "codicon": "kebab-vertical"
        }
    ],

@drobbins-ancile
Copy link

I'd also like to see this as the current profile name is missing from the settings icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants