From 0f9e151c159211a73b423112a7352c979e0b8c2e Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:22:49 +0000
Subject: [PATCH 01/28] Swap to native datepicker

---
 app/views/activities/_form.html.haml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/app/views/activities/_form.html.haml b/app/views/activities/_form.html.haml
index f00f041f6f..6198a02a3c 100644
--- a/app/views/activities/_form.html.haml
+++ b/app/views/activities/_form.html.haml
@@ -40,9 +40,8 @@
           = link_to "Add a planting.", new_planting_path
 
         .col-md-4
-          = f.text_field :due_date,
-                     value: @activity.due_date ? @activity.due_date.to_fs(:ymd) : '',
-                     class: 'add-datepicker', label: 'When?'
+          = f.date_field :due_date,
+                     value: @activity.due_date ? @activity.due_date.to_fs(:ymd) : '', label: 'When?'
 
       %hr
 

From 4b0e228525e47ff06352d557b5b2c6bdb31ed1a8 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:24:20 +0000
Subject: [PATCH 02/28] Swap to native datepicker

---
 app/views/seeds/_form.html.haml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/app/views/seeds/_form.html.haml b/app/views/seeds/_form.html.haml
index a501ac32e4..80a3e05b14 100644
--- a/app/views/seeds/_form.html.haml
+++ b/app/views/seeds/_form.html.haml
@@ -29,19 +29,18 @@
             = link_to "Request new crops.", new_crop_path
       .row
         .col-12.col-md-4
-          = f.text_field :saved_at,
+          = f.date_field :saved_at,
                      value: @seed.saved_at ? @seed.saved_at.to_fs(:ymd) : '',
-                     class: 'add-datepicker', label: 'When were the seeds harvested/saved?'
+                     label: 'When were the seeds harvested/saved?'
         .col-12.col-md-4= f.number_field :quantity, label: 'Quantity'
         .col-12.col-md-4
-          = f.text_field :plant_before, class: 'add-datepicker',
-          value: @seed.plant_before ? @seed.plant_before.to_fs(:ymd) : ''
+          = f.date_field :plant_before, value: @seed.plant_before ? @seed.plant_before.to_fs(:ymd) : ''
 
       .row
         .col-12.col-md-4
           = f.check_box :finished, label: 'Mark as finished'
         .col-12.col-md-4
-          = f.text_field :finished_at, class: 'add-datepicker', value: @seed.finished_at ? @seed.finished_at.to_fs(:ymd) : ''
+          = f.date_field :finished_at, value: @seed.finished_at ? @seed.finished_at.to_fs(:ymd) : ''
         .col-12.col-md-4
           %span.help-inline= t('.finish_helper')
 

From defc3def4fcd04e90430824adbb502dc06fe6033 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:26:16 +0000
Subject: [PATCH 03/28] Allow autosuggests to be required

---
 app/helpers/auto_suggest_helper.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/helpers/auto_suggest_helper.rb b/app/helpers/auto_suggest_helper.rb
index 1b8521c82d..19ebbb1e1e 100644
--- a/app/helpers/auto_suggest_helper.rb
+++ b/app/helpers/auto_suggest_helper.rb
@@ -13,7 +13,7 @@ def auto_suggest(resource, source, options = {})
     resource = resource.class.name.downcase
     source_path = Rails.application.routes.url_helpers.send("search_#{source}s_path", format: :json)
     %(
-      <input id="#{source}" class="auto-suggest #{options[:class]}"
+      <input id="#{source}" class="auto-suggest #{options[:class]}" #{options[:required] ? 'required="required' : ''}
         type="text" value="#{default}" data-source-url="#{source_path}",
         placeholder="e.g. lettuce">
       <noscript class="text-warning">

From bd858a0b23bca457fe776fd0f2ff9842f91f6744 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:26:27 +0000
Subject: [PATCH 04/28] Mark required

---
 app/views/seeds/_form.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/seeds/_form.html.haml b/app/views/seeds/_form.html.haml
index 80a3e05b14..a7ee1fbb48 100644
--- a/app/views/seeds/_form.html.haml
+++ b/app/views/seeds/_form.html.haml
@@ -23,7 +23,7 @@
           = f.hidden_field :parent_planting_id, value: @planting.id
         - else
 
-          = auto_suggest @seed, :crop, class: 'form-control', default: @crop
+          = auto_suggest @seed, :crop, class: 'form-control', default: @crop, required: true
           %span.help-inline
             Can't find what you're looking for?
             = link_to "Request new crops.", new_crop_path

From 3405d224b4b2b27bb7803f7259f50bc377b80742 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:29:17 +0000
Subject: [PATCH 05/28] Add input validations

---
 app/views/seeds/_form.html.haml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/views/seeds/_form.html.haml b/app/views/seeds/_form.html.haml
index a7ee1fbb48..b81c3878a3 100644
--- a/app/views/seeds/_form.html.haml
+++ b/app/views/seeds/_form.html.haml
@@ -32,7 +32,7 @@
           = f.date_field :saved_at,
                      value: @seed.saved_at ? @seed.saved_at.to_fs(:ymd) : '',
                      label: 'When were the seeds harvested/saved?'
-        .col-12.col-md-4= f.number_field :quantity, label: 'Quantity'
+        .col-12.col-md-4= f.number_field :quantity, label: 'Quantity', min: 1
         .col-12.col-md-4
           = f.date_field :plant_before, value: @seed.plant_before ? @seed.plant_before.to_fs(:ymd) : ''
 
@@ -45,6 +45,7 @@
           %span.help-inline= t('.finish_helper')
 
       .row
+        -# TODO: Range control?
         .col-md-6= f.number_field :days_until_maturity_min, label_as_placeholder: true, label: 'min', prepend: 'Days until maturity'
         .col-md-6= f.number_field :days_until_maturity_max, label_as_placeholder: true, label: 'max', prepend: 'to', append: "days"
 

From 329c3ddddd363090b5d3e38248309cb14d3bb839 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:31:59 +0000
Subject: [PATCH 06/28] Mark required

---
 app/views/seeds/_form.html.haml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/views/seeds/_form.html.haml b/app/views/seeds/_form.html.haml
index b81c3878a3..f7c78d21b7 100644
--- a/app/views/seeds/_form.html.haml
+++ b/app/views/seeds/_form.html.haml
@@ -46,21 +46,21 @@
 
       .row
         -# TODO: Range control?
-        .col-md-6= f.number_field :days_until_maturity_min, label_as_placeholder: true, label: 'min', prepend: 'Days until maturity'
-        .col-md-6= f.number_field :days_until_maturity_max, label_as_placeholder: true, label: 'max', prepend: 'to', append: "days"
+        .col-md-6= f.number_field :days_until_maturity_min, label_as_placeholder: true, label: 'min', prepend: 'Days until maturity', min: 1, step: 5
+        .col-md-6= f.number_field :days_until_maturity_max, label_as_placeholder: true, label: 'max', prepend: 'to', append: "days", min: 1, step: 5
 
       .row
         .col-md-4
-          = f.select(:organic, Seed::ORGANIC_VALUES, {label: 'Organic?', wrapper: { class: 'required'}}, default: 'unknown', required: true)
+          = f.select(:organic, Seed::ORGANIC_VALUES, {label: 'Organic?', wrapper: { class: 'required'}, required: true}, default: 'unknown')
         .col-md-4
-          = f.select(:gmo, Seed::GMO_VALUES, {label: 'GMO?', wrapper: { class: 'required'}}, default: 'unknown', required: true)
+          = f.select(:gmo, Seed::GMO_VALUES, {label: 'GMO?', wrapper: { class: 'required'}, required: true}, default: 'unknown')
         .col-md-4
-          = f.select(:heirloom, Seed::HEIRLOOM_VALUES, {label: 'Heirloom?', wrapper: { class: 'required'}}, default: 'unknown', required: true)
+          = f.select(:heirloom, Seed::HEIRLOOM_VALUES, {label: 'Heirloom?', wrapper: { class: 'required' }, required: true}, default: 'unknown')
       = f.text_area :description, rows: 6
 
       %hr/
       =  t('.trade_help', site_name: ENV['GROWSTUFF_SITE_NAME'])
-      = f.select(:tradable_to, Seed::TRADABLE_TO_VALUES, {label: 'Will trade', wrapper: { class: 'required'}})
+      = f.select(:tradable_to, Seed::TRADABLE_TO_VALUES, { label: 'Will trade', required: true, wrapper: { class: 'required '}})
       %span.help_inline
         - if current_member.location.blank?
           Don't forget to

From 4716b33d8207d2047108b8dbdd188739b8b4a728 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:33:35 +0000
Subject: [PATCH 07/28] Mark required

---
 app/views/plantings/_form.html.haml | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/app/views/plantings/_form.html.haml b/app/views/plantings/_form.html.haml
index ef56b46989..93eedb8738 100644
--- a/app/views/plantings/_form.html.haml
+++ b/app/views/plantings/_form.html.haml
@@ -33,7 +33,7 @@
             label: 'Where did you plant it?')
           = link_to "Add a garden.", new_garden_path
         .col-md-4
-          = f.text_field :planted_at,
+          = f.date_field :planted_at,
                      value: @planting.planted_at ? @planting.planted_at.to_fs(:ymd) : '',
                      class: 'add-datepicker', label: 'When?'
           %span.help-inline
@@ -45,7 +45,7 @@
         .col-md-4
           = f.select(:sunniness, Planting::SUNNINESS_VALUES, { include_blank: '', label: 'Sun or shade?' } )
         .col-md-4
-          = f.number_field :quantity, label: 'How many?'
+          = f.number_field :quantity, label: 'How many?', min: 1
       = f.text_area :description, rows: 6, label: 'Tell us more about it'
 
       .row
@@ -53,11 +53,9 @@
           = f.check_box :finished, label: 'Mark as finished'
           %span.help-block= t('.finish_helper')
         .col-md-6
-          = f.text_field :finished_at,
+          = f.date_field :finished_at,
                      value: @planting.finished_at ? @planting.finished_at.to_fs(:ymd) : '',
-                     class: 'add-datepicker',
-                     label: 'Finished date',
-                     placeholder: 'optional'
+                     label: 'Finished date (if known)'
 
     .card-footer
       .text-right= f.submit 'Save'

From 426cb3ed37513a4654b7c7200d173bf6b3d247f5 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:36:16 +0000
Subject: [PATCH 08/28] Remove redundant UI element

---
 app/helpers/application_helper.rb         | 6 ------
 app/helpers/auto_suggest_helper.rb        | 2 +-
 app/views/activities/_form.html.haml      | 1 -
 app/views/gardens/_form.html.haml         | 1 -
 app/views/harvests/_form.html.haml        | 3 +--
 app/views/plantings/_form.html.haml       | 1 -
 app/views/seeds/_form.html.haml           | 1 -
 app/views/shared/editable/_date.html.haml | 2 +-
 app/views/shared/editable/_form.html.haml | 2 +-
 spec/helpers/application_helper_spec.rb   | 7 -------
 10 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index ee1b6d7e28..992dc1b6bd 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -28,12 +28,6 @@ def cache_key_for(klass, identifier = "all")
     "#{klass.name.downcase.pluralize}/#{identifier}-#{count}-#{max_updated_at}"
   end
 
-  def required_field_help_text
-    asterisk = tag.span('*', class: ['red'])
-    text = tag.em('denotes a required field')
-    tag.div(asterisk + ' '.html_safe + text, class: ['margin-bottom'])
-  end
-
   # A helper to replace the complex template compilation mess
   # of HAML, Tilt, and dynamic compilation with interpolated ruby.
   def markdownify(text)
diff --git a/app/helpers/auto_suggest_helper.rb b/app/helpers/auto_suggest_helper.rb
index 19ebbb1e1e..ff0558ef27 100644
--- a/app/helpers/auto_suggest_helper.rb
+++ b/app/helpers/auto_suggest_helper.rb
@@ -13,7 +13,7 @@ def auto_suggest(resource, source, options = {})
     resource = resource.class.name.downcase
     source_path = Rails.application.routes.url_helpers.send("search_#{source}s_path", format: :json)
     %(
-      <input id="#{source}" class="auto-suggest #{options[:class]}" #{options[:required] ? 'required="required' : ''}
+      <input id="#{source}" class="auto-suggest #{options[:class]}" #{options[:required] ? 'required="required"' : ''}
         type="text" value="#{default}" data-source-url="#{source_path}",
         placeholder="e.g. lettuce">
       <noscript class="text-warning">
diff --git a/app/views/activities/_form.html.haml b/app/views/activities/_form.html.haml
index 6198a02a3c..80f700a116 100644
--- a/app/views/activities/_form.html.haml
+++ b/app/views/activities/_form.html.haml
@@ -6,7 +6,6 @@
         %strong=yield :title
   = bootstrap_form_for(@activity) do |f|
     .card-body
-      = required_field_help_text
       - if @activity.errors.any?
         #error_explanation
           %h2
diff --git a/app/views/gardens/_form.html.haml b/app/views/gardens/_form.html.haml
index 8ab82bc9b4..a406e81c98 100644
--- a/app/views/gardens/_form.html.haml
+++ b/app/views/gardens/_form.html.haml
@@ -5,7 +5,6 @@
         %h1.h2-responsive.text-center
           %strong=yield :title
     .card-body
-      = required_field_help_text
       - if @garden.errors.any?
         #error_explanation.alert.alert-warning{:role => "alert"}
           %h4.alert-heading
diff --git a/app/views/harvests/_form.html.haml b/app/views/harvests/_form.html.haml
index c225e53798..25c9a22e9e 100644
--- a/app/views/harvests/_form.html.haml
+++ b/app/views/harvests/_form.html.haml
@@ -7,7 +7,6 @@
           = harvest_icon
           %strong=yield :title
     .card-body
-      = required_field_help_text
       - if @harvest.errors.any?
         #error_explanation
           %h2 #{pluralize(@harvest.errors.size, "error")} prohibited this harvest from being saved:"
@@ -31,7 +30,7 @@
                 = link_to "Request new crops.", new_crop_path
 
         .col-md-4
-          = f.text_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_fs(:ymd) : '',
+          = f.date_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_fs(:ymd) : '',
                          class: 'add-datepicker', label: 'When?'
         .col-12
           = f.form_group :plant_part_id, label: { text: "Harvested Plant Part" } do
diff --git a/app/views/plantings/_form.html.haml b/app/views/plantings/_form.html.haml
index 93eedb8738..57672605c4 100644
--- a/app/views/plantings/_form.html.haml
+++ b/app/views/plantings/_form.html.haml
@@ -6,7 +6,6 @@
         %strong=yield :title
   = bootstrap_form_for(@planting) do |f|
     .card-body
-      = required_field_help_text
       - if @planting.errors.any?
         #error_explanation
           %h2
diff --git a/app/views/seeds/_form.html.haml b/app/views/seeds/_form.html.haml
index f7c78d21b7..a37bb9ffd3 100644
--- a/app/views/seeds/_form.html.haml
+++ b/app/views/seeds/_form.html.haml
@@ -14,7 +14,6 @@
           %ul
             - @seed.errors.full_messages.each do |msg|
               %li= msg
-      = required_field_help_text
 
       .form-group.required
         = f.label :crop, 'Crop'
diff --git a/app/views/shared/editable/_date.html.haml b/app/views/shared/editable/_date.html.haml
index 1e570b8de1..e4c34ac86f 100644
--- a/app/views/shared/editable/_date.html.haml
+++ b/app/views/shared/editable/_date.html.haml
@@ -5,7 +5,7 @@
       = edit_icon
   .hide{id: "date--#{model.id}-#{field.to_s}"}
     = bootstrap_form_for(model) do |f|
-      = f.text_field field,
+      = f.date_field field,
                value: model.send(field) ? model.send(field).to_fs(:ymd) : '',
                class: 'add-datepicker', label: 'When?'
       = f.submit :save
diff --git a/app/views/shared/editable/_form.html.haml b/app/views/shared/editable/_form.html.haml
index 69b79cbcf3..4b57b45ba7 100644
--- a/app/views/shared/editable/_form.html.haml
+++ b/app/views/shared/editable/_form.html.haml
@@ -12,7 +12,7 @@
       - elsif field_type == :select
         = f.select field, collection
       - elsif field_type == :date
-        = f.text_field field,
+        = f.date_field field,
                  value: model.send(field) ? model.send(field).to_fs(:ymd) : '',
                  class: 'add-datepicker', label: 'When?'
       = f.submit :save
diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb
index 042dd8ffc0..09c57d1acf 100644
--- a/spec/helpers/application_helper_spec.rb
+++ b/spec/helpers/application_helper_spec.rb
@@ -10,13 +10,6 @@
     parse_date('may 12th 2012').should eq Date.new(2012, 5, 12)
   end
 
-  it "shows required field marker help text with proper formatting" do
-    output = required_field_help_text
-    expect(output).to have_selector '.margin-bottom'
-    expect(output).to have_selector '.red', text: '*'
-    expect(output).to have_selector 'em', text: 'denotes a required field'
-  end
-
   describe '#avatar_uri' do
     context 'with a normal user' do
       before do

From 03f8acdd1d4dc74371d2b64856d71c68209332eb Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:41:22 +0000
Subject: [PATCH 09/28] Add placehikder

---
 app/views/activities/_form.html.haml | 3 +--
 app/views/gardens/_form.html.haml    | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/views/activities/_form.html.haml b/app/views/activities/_form.html.haml
index 80f700a116..02a89abcd4 100644
--- a/app/views/activities/_form.html.haml
+++ b/app/views/activities/_form.html.haml
@@ -39,8 +39,7 @@
           = link_to "Add a planting.", new_planting_path
 
         .col-md-4
-          = f.date_field :due_date,
-                     value: @activity.due_date ? @activity.due_date.to_fs(:ymd) : '', label: 'When?'
+          = f.date_field :due_date, value: @activity.due_date ? @activity.due_date.to_fs(:ymd) : '', label: 'When?'
 
       %hr
 
diff --git a/app/views/gardens/_form.html.haml b/app/views/gardens/_form.html.haml
index a406e81c98..e6884d83bb 100644
--- a/app/views/gardens/_form.html.haml
+++ b/app/views/gardens/_form.html.haml
@@ -15,7 +15,7 @@
               %li= msg
 
       = f.text_field :name, maxlength: 255, required: true
-      = f.text_area :description, rows: 6
+      = f.text_area :description, rows: 6, placeholder: "Share more about this garden - when did you first start it? How is it watered? Are you focused on any particular techniques? What are your plans and goals?"
       = f.text_field :location,
                       value: @garden.location || current_member.location,
                       class: 'form-control', maxlength: 255
@@ -26,7 +26,7 @@
         - else
           = link_to "Change your location.", edit_member_registration_path
       .row
-        .col-md-5.col-12= f.number_field :area, class: 'input-small', step: "any"
+        .col-md-5.col-12= f.number_field :area, class: 'input-small', step: "any", min: 0
         .col-md-7.col-12= f.select(:area_unit, Garden::AREA_UNITS_VALUES, { include_blank: false })
         .col-12= f.select(:garden_type_id, GardenType.all.order(:name).pluck(:name, :id),
                           selected: @garden.garden_type_id, include_blank: true)

From c78a347002c48ac7a6a084e13ace610ce3274a66 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 02:59:41 +0000
Subject: [PATCH 10/28] Mark required

---
 app/views/harvests/_form.html.haml | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/views/harvests/_form.html.haml b/app/views/harvests/_form.html.haml
index 25c9a22e9e..230a44876e 100644
--- a/app/views/harvests/_form.html.haml
+++ b/app/views/harvests/_form.html.haml
@@ -30,8 +30,7 @@
                 = link_to "Request new crops.", new_crop_path
 
         .col-md-4
-          = f.date_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_fs(:ymd) : '',
-                         class: 'add-datepicker', label: 'When?'
+          = f.date_field :harvested_at, value: @harvest.harvested_at ? @harvest.harvested_at.to_fs(:ymd) : '', label: 'When?', required: true
         .col-12
           = f.form_group :plant_part_id, label: { text: "Harvested Plant Part" } do
             .row
@@ -43,12 +42,12 @@
       -# http://blog.isotoma.com/2012/03/html5-input-typenumber-and-decimalsfloats-in-chrome/
       .row
         .col-md-4
-          = f.number_field :quantity, class: 'input-small form-control', step: 'any', label: 'How many?'
+          = f.number_field :quantity, class: 'input-small form-control', step: 'any', label: 'How many?', min: 1
         .col-md-8
           = f.select(:unit, Harvest::UNITS_VALUES, { include_blank: false }, class: 'input-medium form-control')
       .row
         .col-md-4
-          = f.number_field :weight_quantity, class: 'input-small form-control', step: 'any', label: 'Weighing (in total)'
+          = f.number_field :weight_quantity, class: 'input-small form-control', step: 'any', label: 'Weighing (in total)', min: 1
         .col-md-8
           = f.select(:weight_unit, Harvest::WEIGHT_UNITS_VALUES, { include_blank: false }, class: 'form-control')
       = f.text_area :description, rows: 6, label: 'Notes'

From 195602288c04fe06339148db5173b3fdae44e1b8 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 03:29:29 +0000
Subject: [PATCH 11/28] Fix test

---
 spec/views/plantings/_form.html.haml_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/views/plantings/_form.html.haml_spec.rb b/spec/views/plantings/_form.html.haml_spec.rb
index 0dc7a5a1a8..8634b19e19 100644
--- a/spec/views/plantings/_form.html.haml_spec.rb
+++ b/spec/views/plantings/_form.html.haml_spec.rb
@@ -22,6 +22,6 @@
   end
 
   it "has a free-form text field containing the planting date in ISO format" do
-    assert_select "input#planting_planted_at[type='text'][value='2013-03-01']"
+    assert_select "input#planting_planted_at[type='date'][value='2013-03-01']"
   end
 end

From fe0d4295be67abef31a63179ad8ce039f8b55503 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 03:57:53 +0000
Subject: [PATCH 12/28] Spec no longer possible

---
 spec/features/gardens/gardens_spec.rb | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/spec/features/gardens/gardens_spec.rb b/spec/features/gardens/gardens_spec.rb
index eea33d67df..6eadfa5add 100644
--- a/spec/features/gardens/gardens_spec.rb
+++ b/spec/features/gardens/gardens_spec.rb
@@ -52,15 +52,6 @@
       expect(page).to have_content "New garden"
     end
 
-    it "Refuse to create new garden with negative area" do
-      visit new_garden_path
-      fill_in "Name", with: "Negative Garden"
-      fill_in "Area", with: -5
-      click_button "Save"
-      expect(page).to have_no_content "Garden was successfully created"
-      expect(page).to have_content "Area must be greater than or equal to 0"
-    end
-
     context "Clicking edit from the index page" do
       before do
         visit gardens_path

From a5f774f043775d15a12b9e50b084af5f09b5636f Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 03:59:12 +0000
Subject: [PATCH 13/28] Spec no longer possible

---
 app/assets/stylesheets/_plantings.scss | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/assets/stylesheets/_plantings.scss b/app/assets/stylesheets/_plantings.scss
index 0b3d378749..98f6cf8625 100755
--- a/app/assets/stylesheets/_plantings.scss
+++ b/app/assets/stylesheets/_plantings.scss
@@ -49,11 +49,11 @@
   }
 
   .card-footer {
-      max-height: 2em;
-      -webkit-line-clamp: 1;
-      overflow: hidden;
-      text-overflow: ellipsis;
-      margin-bottom: 0.5em;
-      padding-top: 0;
+    max-height: 2em;
+    -webkit-line-clamp: 1;
+    overflow: hidden;
+    text-overflow: ellipsis;
+    margin-bottom: 0.5em;
+    padding-top: 0;
   }
 }

From 9c6797e85051be3e8938bdb38bdb325d4dab750f Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 08:17:40 +0000
Subject: [PATCH 14/28] Swap to html5 control

---
 spec/features/plantings/planting_a_crop_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index c563e6f54f..8580f321ac 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -189,7 +189,7 @@
       click_link 'Actions'
       click_link "Edit"
       check "finished"
-      fill_in "Finished date", with: "2015-06-25"
+      fill_in "Finished date", with: Time.new(2015, 06, 25)
       click_button "Save"
       expect(page).to have_content "planting was successfully updated"
       expect(page).to have_content "Finished"

From 4c8c54eadd7aa7f42b4e7b9878a0a3f7123b2ce2 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 08:48:42 +0000
Subject: [PATCH 15/28] Fix specs

---
 spec/features/gardens/adding_gardens_spec.rb     | 4 ----
 spec/features/harvests/harvesting_a_crop_spec.rb | 4 ----
 spec/features/plantings/planting_a_crop_spec.rb  | 4 ----
 spec/features/seeds/adding_seeds_spec.rb         | 4 ----
 4 files changed, 16 deletions(-)

diff --git a/spec/features/gardens/adding_gardens_spec.rb b/spec/features/gardens/adding_gardens_spec.rb
index 9dc30df015..ce699d6720 100644
--- a/spec/features/gardens/adding_gardens_spec.rb
+++ b/spec/features/gardens/adding_gardens_spec.rb
@@ -10,10 +10,6 @@
 
     include_examples 'is accessible'
 
-    it "has the required fields help text" do
-      expect(page).to have_content "* denotes a required field"
-    end
-
     it "displays required and optional fields properly" do
       expect(page).to have_selector ".required", text: "Name"
       expect(page).to have_selector 'textarea#garden_description'
diff --git a/spec/features/harvests/harvesting_a_crop_spec.rb b/spec/features/harvests/harvesting_a_crop_spec.rb
index 765ddd2450..d69ecdde6f 100644
--- a/spec/features/harvests/harvesting_a_crop_spec.rb
+++ b/spec/features/harvests/harvesting_a_crop_spec.rb
@@ -13,10 +13,6 @@
 
     it_behaves_like "crop suggest", "harvest", "crop"
 
-    it "has the required fields help text" do
-      expect(page).to have_content "* denotes a required field"
-    end
-
     describe "displays required and optional fields properly" do
       it { expect(page).to have_selector ".required", text: "What did you harvest?" }
       it { expect(page).to have_selector 'input#harvest_quantity' }
diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index 8580f321ac..7470889167 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -18,10 +18,6 @@
 
     it_behaves_like "crop suggest", "planting"
 
-    it "has the required fields help text" do
-      expect(page).to have_content "* denotes a required field"
-    end
-
     describe "displays required and optional fields properly" do
       it { expect(page).to have_selector ".required", text: "What did you plant?" }
       it { expect(page).to have_selector ".required", text: "Where did you plant it?" }
diff --git a/spec/features/seeds/adding_seeds_spec.rb b/spec/features/seeds/adding_seeds_spec.rb
index 7f072aaceb..01b42ea570 100644
--- a/spec/features/seeds/adding_seeds_spec.rb
+++ b/spec/features/seeds/adding_seeds_spec.rb
@@ -12,10 +12,6 @@
 
     it_behaves_like "crop suggest", "seed", "crop"
 
-    it "has the required fields help text" do
-      expect(page).to have_content "* denotes a required field"
-    end
-
     describe "displays required and optional fields properly" do
       # NOTE: The required behaviour is pushed down to the control itself, not the form-group as of rails 7.1.
       # Modern browsers enforce the required behaviour better than us doing it ourselves.

From 8aa0f981962101ecef440ae99abda4664000218c Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 09:00:00 +0000
Subject: [PATCH 16/28] Fix specs

---
 spec/features/plantings/planting_a_crop_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index 7470889167..b5864aaa10 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -198,7 +198,7 @@
       within "form#new_planting" do
         fill_in "When?", with: "2014-07-01"
         check "Mark as finished"
-        fill_in "Finished date", with: "2014-08-30"
+        fill_in "Finished date", with: Time.new(2014, 8, 30)
         uncheck 'Mark as finished'
       end
 

From 69e764dd63268b7281f0ace235a2b2967dc14d48 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 09:01:29 +0000
Subject: [PATCH 17/28] Fix specs

---
 spec/features/plantings/planting_a_crop_spec.rb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index b5864aaa10..9594d04d9f 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -62,9 +62,9 @@
       before do
         visit new_planting_path
 
-        @a_past_date = 15.days.ago.strftime("%Y-%m-%d")
-        @right_now = Time.zone.today.strftime("%Y-%m-%d")
-        @a_future_date = 1.year.from_now.strftime("%Y-%m-%d")
+        @a_past_date = 15.days.ago
+        @right_now = Time.zone.today
+        @a_future_date = 1.year.from_now
       end
 
       it "shows that it is not planted yet" do
@@ -111,7 +111,7 @@
           fill_in "How many?", with: 42
           select "cutting", from: "Planted from"
           select "semi-shade", from: "Sun or shade?"
-          fill_in "When?", with: '2013-03-10'
+          fill_in "When?", with: Time.new(2013, 3, 10)
           fill_in "Tell us more about it", with: "It's rad."
           fill_in "Finished date", with: @a_future_date
           click_button "Save"

From dddc85c3383638b0ecf55f2713cd06028e96939d Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 09:19:10 +0000
Subject: [PATCH 18/28] Fix specs

---
 spec/features/seeds/adding_seeds_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/seeds/adding_seeds_spec.rb b/spec/features/seeds/adding_seeds_spec.rb
index 01b42ea570..40542113d8 100644
--- a/spec/features/seeds/adding_seeds_spec.rb
+++ b/spec/features/seeds/adding_seeds_spec.rb
@@ -33,7 +33,7 @@
         select_from_autocomplete "maize"
         within "form#new_seed" do
           fill_in "Quantity", with: 42
-          fill_in "Plant before", with: "2014-06-15"
+          fill_in "Plant before", with: TIme.new(2014, 6, 15)
           fill_in "min", with: 999
           fill_in "max", with: 1999
           select "certified organic", from: "Organic?"

From c6b5cc61dab18650989f234b0ff690d085e0a5e3 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 09:30:36 +0000
Subject: [PATCH 19/28] Fix specs

---
 spec/features/seeds/adding_seeds_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/seeds/adding_seeds_spec.rb b/spec/features/seeds/adding_seeds_spec.rb
index 40542113d8..6db977735d 100644
--- a/spec/features/seeds/adding_seeds_spec.rb
+++ b/spec/features/seeds/adding_seeds_spec.rb
@@ -29,7 +29,7 @@
 
     describe "Adding a new seed", :js do
       before do
-        fill_autocomplete "crop", with: "mai"
+        fill_autocomplete "crop", with: " "
         select_from_autocomplete "maize"
         within "form#new_seed" do
           fill_in "Quantity", with: 42

From 0e1578aeefa3bf72621be776d6cd966d76ce40f9 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 09:45:10 +0000
Subject: [PATCH 20/28] Fix specs

---
 app/views/seeds/_form.html.haml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/seeds/_form.html.haml b/app/views/seeds/_form.html.haml
index a37bb9ffd3..2782696585 100644
--- a/app/views/seeds/_form.html.haml
+++ b/app/views/seeds/_form.html.haml
@@ -45,8 +45,8 @@
 
       .row
         -# TODO: Range control?
-        .col-md-6= f.number_field :days_until_maturity_min, label_as_placeholder: true, label: 'min', prepend: 'Days until maturity', min: 1, step: 5
-        .col-md-6= f.number_field :days_until_maturity_max, label_as_placeholder: true, label: 'max', prepend: 'to', append: "days", min: 1, step: 5
+        .col-md-6= f.number_field :days_until_maturity_min, label_as_placeholder: true, label: 'min', prepend: 'Days until maturity', min: 1
+        .col-md-6= f.number_field :days_until_maturity_max, label_as_placeholder: true, label: 'max', prepend: 'to', append: "days", min: 1
 
       .row
         .col-md-4

From 5128c8be0e5d966c9b1e9719291c403c7d696f69 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 09:55:20 +0000
Subject: [PATCH 21/28] Fix specs

---
 spec/features/plantings/planting_a_crop_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index 9594d04d9f..97621d52f7 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -196,7 +196,7 @@
       select_from_autocomplete "maize"
       choose(member.gardens.first.name)
       within "form#new_planting" do
-        fill_in "When?", with: "2014-07-01"
+        fill_in "When?", with: Time.new(2014, 7, 1)
         check "Mark as finished"
         fill_in "Finished date", with: Time.new(2014, 8, 30)
         uncheck 'Mark as finished'

From 654aa318c4b51f44952a1c1e09e409223f529d68 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 10:05:52 +0000
Subject: [PATCH 22/28] Fix specs

---
 spec/features/plantings/planting_a_crop_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index 97621d52f7..9ab4fe7bde 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -253,7 +253,7 @@
         fill_autocomplete "crop", with: "mai"
         select_from_autocomplete "maize"
         within "form#new_planting" do
-          fill_in "When", with: "2015-10-15"
+          fill_in "When", with: Time.new(2015, 10, 15)
           fill_in "How many?", with: 42
           select "cutting", from: "Planted from"
           select "sun", from: "Sun or shade?"

From 65a0540e3d0ed600272760535c3bc1f840ddf182 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 10:19:51 +0000
Subject: [PATCH 23/28] Mark spec pending

---
 spec/features/plantings/planting_a_crop_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index 9ab4fe7bde..a51b73b20d 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -191,7 +191,7 @@
       expect(page).to have_content "Finished"
     end
 
-    it "Marking a planting as finished" do
+    pending "Marking a planting as finished" do
       fill_autocomplete "crop", with: "mai"
       select_from_autocomplete "maize"
       choose(member.gardens.first.name)

From f89d64ac3ac15edaf3bc28a7f7ac3e15ab8ea25c Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 10:28:29 +0000
Subject: [PATCH 24/28] Mark spec pending

---
 spec/features/seeds/adding_seeds_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/seeds/adding_seeds_spec.rb b/spec/features/seeds/adding_seeds_spec.rb
index 6db977735d..cdaf4d6ed0 100644
--- a/spec/features/seeds/adding_seeds_spec.rb
+++ b/spec/features/seeds/adding_seeds_spec.rb
@@ -29,7 +29,7 @@
 
     describe "Adding a new seed", :js do
       before do
-        fill_autocomplete "crop", with: " "
+        fill_autocomplete "crop", with: "maiz"
         select_from_autocomplete "maize"
         within "form#new_seed" do
           fill_in "Quantity", with: 42

From 8d40355355e78be8e1d1508c1b09145c145a66e0 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 22:51:04 +1030
Subject: [PATCH 25/28] Update app/views/harvests/_form.html.haml

---
 app/views/harvests/_form.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/harvests/_form.html.haml b/app/views/harvests/_form.html.haml
index 230a44876e..4a9b205ab5 100644
--- a/app/views/harvests/_form.html.haml
+++ b/app/views/harvests/_form.html.haml
@@ -47,7 +47,7 @@
           = f.select(:unit, Harvest::UNITS_VALUES, { include_blank: false }, class: 'input-medium form-control')
       .row
         .col-md-4
-          = f.number_field :weight_quantity, class: 'input-small form-control', step: 'any', label: 'Weighing (in total)', min: 1
+          = f.number_field :weight_quantity, class: 'input-small form-control', step: 'any', label: 'Weighing (in total)'
         .col-md-8
           = f.select(:weight_unit, Harvest::WEIGHT_UNITS_VALUES, { include_blank: false }, class: 'form-control')
       = f.text_area :description, rows: 6, label: 'Notes'

From e1270512dc8517ccff46a756ac0c9b93f8aa44ce Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 22:52:05 +1030
Subject: [PATCH 26/28] Update app/views/seeds/_form.html.haml

---
 app/views/seeds/_form.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/views/seeds/_form.html.haml b/app/views/seeds/_form.html.haml
index 2782696585..db4f97f5cd 100644
--- a/app/views/seeds/_form.html.haml
+++ b/app/views/seeds/_form.html.haml
@@ -59,7 +59,7 @@
 
       %hr/
       =  t('.trade_help', site_name: ENV['GROWSTUFF_SITE_NAME'])
-      = f.select(:tradable_to, Seed::TRADABLE_TO_VALUES, { label: 'Will trade', required: true, wrapper: { class: 'required '}})
+      = f.select(:tradable_to, Seed::TRADABLE_TO_VALUES, { label: 'Will trade', required: true, wrapper: { class: 'required' }})
       %span.help_inline
         - if current_member.location.blank?
           Don't forget to

From 7102552bfe3874c9bfa33b8b95ea57b5dbd13213 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 22:52:39 +1030
Subject: [PATCH 27/28] Update spec/features/seeds/adding_seeds_spec.rb

---
 spec/features/seeds/adding_seeds_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/seeds/adding_seeds_spec.rb b/spec/features/seeds/adding_seeds_spec.rb
index cdaf4d6ed0..40542113d8 100644
--- a/spec/features/seeds/adding_seeds_spec.rb
+++ b/spec/features/seeds/adding_seeds_spec.rb
@@ -29,7 +29,7 @@
 
     describe "Adding a new seed", :js do
       before do
-        fill_autocomplete "crop", with: "maiz"
+        fill_autocomplete "crop", with: "mai"
         select_from_autocomplete "maize"
         within "form#new_seed" do
           fill_in "Quantity", with: 42

From 035decb132f9421d81f1babe1398b29ec7fa04c2 Mon Sep 17 00:00:00 2001
From: Daniel O'Connor <daniel.oconnor@gmail.com>
Date: Sun, 13 Oct 2024 22:53:17 +1030
Subject: [PATCH 28/28] Update spec/features/plantings/planting_a_crop_spec.rb

---
 spec/features/plantings/planting_a_crop_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/plantings/planting_a_crop_spec.rb b/spec/features/plantings/planting_a_crop_spec.rb
index a51b73b20d..9ab4fe7bde 100644
--- a/spec/features/plantings/planting_a_crop_spec.rb
+++ b/spec/features/plantings/planting_a_crop_spec.rb
@@ -191,7 +191,7 @@
       expect(page).to have_content "Finished"
     end
 
-    pending "Marking a planting as finished" do
+    it "Marking a planting as finished" do
       fill_autocomplete "crop", with: "mai"
       select_from_autocomplete "maize"
       choose(member.gardens.first.name)