Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subbeamnod() should be renamed #451

Open
mpound opened this issue Jan 22, 2025 · 1 comment
Open

subbeamnod() should be renamed #451

mpound opened this issue Jan 22, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@mpound
Copy link
Collaborator

mpound commented Jan 22, 2025

Feature description
subbeamnod() method of GBTFITSLoad is the only calibration routine that doesn't start with get. Initially, we thought we would not be using getthis, getthat, and I named subbeamnod accordingly. However, we have used get so, we should change it to getsbnod or something like that.

Solution
Straightforward substitution but requires tests, notebooks, and documentation to change too.

@mpound mpound added the enhancement New feature or request label Jan 22, 2025
@teuben
Copy link
Collaborator

teuben commented Jan 23, 2025

I second this, but I could also argue to call it getnodsb() instead. This to favor those that use TAB-completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants