Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ckeditor version error #88

Open
casesolved-co-uk opened this issue Jul 12, 2024 · 5 comments
Open

Upgrade ckeditor version error #88

casesolved-co-uk opened this issue Jul 12, 2024 · 5 comments

Comments

@casesolved-co-uk
Copy link

casesolved-co-uk commented Jul 12, 2024

I'm using plugin version 1.0.1 but am getting the following error when editing a text component:

Screen Shot 2024-07-12 at 23 49 28

It wants version 4.21.0 to go to 4.24.0

Trying to upgrade it looks like only the typescript definitions are used:
"@types/ckeditor4": "^4.20.0"
Which only goes up to 4.20.7

The website says this:

Keep CKEditor 4safe and secure
CKEditor 4 reached its End-of-Life with no updates, security patches or bug fixes.

Looks like they're on ckeditor version 5:

https://www.npmjs.com/package/ckeditor5
https://github.com/ckeditor/ckeditor5#

Are there any plans to upgrade?

Related:
#30
#63

@allphat
Copy link

allphat commented Jul 17, 2024

you can pass an option to the editor plugin.
the ckeditor4 option to pass is "versionCheck: false"

@patriktoth67
Copy link

Hello!

After adding this option, I still see the error popup.

I can't seem to figure out what the issue is.

<script setup>
import grapesjs from "grapesjs";
import "grapesjs/dist/css/grapes.min.css";
import grapesjsPresetNewsletter from "grapesjs-preset-newsletter";
import grapesjsPluginCkeditor from "grapesjs-plugin-ckeditor";
import grapesJSMJML from "grapesjs-mjml";

const editor = grapesjs.init({
        container: "#gjs",
        fromElement: true,
        plugins: [grapesjsPresetNewsletter, grapesjsPluginCkeditor, grapesJSMJML],
        pluginsOpts: {
            [grapesjsPluginCkeditor]: {
                versionCheck: false,
            },
        },
        
        ...

Any ideas why?

@allphat
Copy link

allphat commented Sep 3, 2024

you have to declare versionCheck under "options"
something like this

const editor = grapesjs.init({
        container: "#gjs",
        fromElement: true,
        plugins: [grapesjsPresetNewsletter, grapesjsPluginCkeditor, grapesJSMJML],
        pluginsOpts: {
            [grapesjsPluginCkeditor]: {
              options: {  
                versionCheck: false,
                //other options...
               }
            },
        },
        
        ...

@patriktoth67
Copy link

Ahh thank you for the quick help!:)

@casesolved-co-uk
Copy link
Author

There's an example here:
#30 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants