Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content trust support #1544

Open
rmannibucau opened this issue Mar 9, 2019 · 5 comments
Open

Content trust support #1544

rmannibucau opened this issue Mar 9, 2019 · 5 comments

Comments

@rmannibucau
Copy link
Contributor

Description of the issue:

Add support for signed image , aka content trust.

Expected behavior:

Add a key config in the builder to sign the image and wire it in build plugins. For mavennit will use servers typically.

Steps to reproduce:

Environment:

jib-maven-plugin Configuration:

PASTE YOUR pom.xml CONFIGURATION HERE

jib-gradle-plugin Configuration:

PASTE YOUR build.gradle CONFIGURATION HERE

Log output:

Additional Information:

@chanseokoh
Copy link
Member

chanseokoh commented Mar 11, 2019

Not sure if we will look into this soon, but I have briefly gone over the Docker Content Trust (DCT) doc to see what it is, but I'm still completely lost in how exactly this can be implemented in Jib. I'd appreciate if you could give us pointers or guidance in terms of what needs to be done on the Jib side implementation-wise. Even high-level descriptions would help. Best if you can contribute to our code directly. :)

@rmannibucau
Copy link
Contributor Author

I'm not fully sure of the "how" - by guess reading quickly the sources is that it is mainly interacting with a notary server and signing a tag (the digest only?). Main goal is to enforce the from to be a signed image and let a produced image be used in a from in a docker file using content trust.

@bademux
Copy link

bademux commented Dec 16, 2021

Hi,
looks like it will be the only option to use DCT with Jib while relying on imageDigest.
It appears that docker trust sign overrides Jib's manifest,
and even more docker pull myimage and then docker pull myimage has the same effect imageDigest is changed (manifest.json is reformatted)
Tested with 20.10.7 and Artifactory 6.17.0

ref docker/cli#3394

@benruland
Copy link

benruland commented Sep 20, 2023

Signing images and using technologies such as cosign / sigstore has gained a lot of popularity and adoption, driven by the need for supply-chain security. Would you reconsider prioritizing this issue?

@apakhomov
Copy link

+1 for feature

@blakeli0 blakeli0 added enhancement and removed question User inquiries labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants