Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Scopes not set appropriately when passing Creds directly into DataframeFunction #227

Closed
kmaphoenix opened this issue Aug 30, 2024 · 0 comments · Fixed by #228
Closed

[BUG] Scopes not set appropriately when passing Creds directly into DataframeFunction #227

kmaphoenix opened this issue Aug 30, 2024 · 0 comments · Fixed by #228
Assignees
@kmaphoenix
Labels
bug Something isn't working dataframes Issues or Features with Pandas Dataframes

Comments

@kmaphoenix
Copy link
Member

TLDR

Scopes not set appropriately when passing Creds directly into DataframeFunction

Details

If a credentials object is passed in directly to the class, the GLOBAL_SCOPE isn't appended to the existing scope before instantiating the sheets client
https://github.com/GoogleCloudPlatform/dfcx-scrapi/blob/main/src/dfcx_scrapi/tools/dataframe_functions.py#L72
@kmaphoenix kmaphoenix added the bug Something isn't working label Aug 30, 2024
@kmaphoenix kmaphoenix self-assigned this Aug 30, 2024
@kmaphoenix kmaphoenix added the dataframes Issues or Features with Pandas Dataframes label Aug 30, 2024
@kmaphoenix kmaphoenix linked a pull request Sep 3, 2024 that will close this issue
Fix/scopes dataframe functions #228
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmaphoenix kmaphoenix

Labels
bug Something isn't working dataframes Issues or Features with Pandas Dataframes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/scopes dataframe functions GoogleCloudPlatform/dfcx-scrapi
1 participant
@kmaphoenix