Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples using the new sidecar/initContainers features in Kubernetes 1.29. #2261

Open
rshade opened this issue Jul 4, 2024 · 8 comments
Open
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rshade
Copy link

rshade commented Jul 4, 2024

Feature Description

Would it be possible to update the k8s examples to use the new sidecar features in Kubernetes 1.29, or possibly do a new example. It seems like the new sidecars are the right route for cloud-sql-proxy.

Sample code

I don't currently have a sample implementation.

Alternatives Considered

No response

Additional Details

No response

@rshade rshade added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 4, 2024
@jackwotherspoon jackwotherspoon added type: docs Improvement to the documentation for an API. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jul 4, 2024
@jackwotherspoon
Copy link
Collaborator

Hi @rshade, this sounds like a great idea! 😄 We will definitely take a look at the sidecar features and see where we can update our examples to leverage them.

If you get to playing around with the feature before us, feel free to follow-up here with your example or even put up a PR, we always welcome external contributions 😄

Thanks again!

@enocom
Copy link
Member

enocom commented Jul 8, 2024

Here's an almost complete example for AlloyDB which would be practically identical for Cloud SQL: GoogleCloudPlatform/alloydb-auth-proxy#662 (comment)

@hessjcg
Copy link
Collaborator

hessjcg commented Jul 10, 2024

I agree that this is a good idea. The K8s Sidecar Container is in beta in Kubernetes 1.29. We would like to add support for this to the Proxy Operator (See GoogleCloudPlatform/cloud-sql-proxy-operator#381) but have not committed to a timeline.

@enocom
Copy link
Member

enocom commented Aug 5, 2024

There's a nice example here too: #128 (comment). That shows how to properly configure the Proxy with the new sidecar feature + a startup probe.

cc @devauxbr

@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 5, 2024
@manueljishi
Copy link

Hi! I have been watching the examples and I would say they all have one thing in common: They all explicitly define the sidecar containers. Is this an expected behaviour? Would AuthProxyWorkloads be able to have some configuration to implement this configuration?

@jackwotherspoon
Copy link
Collaborator

Is this an expected behaviour? Would AuthProxyWorkloads be able to have some configuration to implement this configuration?

Hi @manueljishi, the AuthProxyWorkload (i.e. the Cloud SQL Proxy Operator) is indeed a ready to use alternative to explicitly defining the sidecar container youself.

Some users and use cases prefer the additional flexibility and full control of defining the sidecar container and startup behavior themselves which is why we provide additional examples in this repo.

@manueljishi
Copy link

Hi @jackwotherspoon thanks for your response!
I think I mixed a couple of concepts, I was referring to the features explained here

@jackwotherspoon
Copy link
Collaborator

@manueljishi This issue and GoogleCloudPlatform/cloud-sql-proxy-operator#381 are for the same exact thing essentially.

This issue is for showcasing examples of using the Proxy with the new sidecar features in Kubernetes 1.29+ while the Operator issue is to add the new features in the Operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants