Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stockpile groups behave incorrectly with filters #484

Open
GoldenGnu opened this issue Sep 18, 2024 · 0 comments
Open

Stockpile groups behave incorrectly with filters #484

GoldenGnu opened this issue Sep 18, 2024 · 0 comments
Labels
bug Defect done This feature will be included in the next feature release stockpile Stockpile Tool

Comments

@GoldenGnu
Copy link
Owner

  1. Stockpile groups can incorrectly become hidden when collapsed with matching items in the group. This is due to the items being replaced by the IgnoreItem, that does not match anything.

Instead of using the IgnoreItem simply putting all the items in the same separator resolve the issue.

  1. The stockpile group are not rendered if the first stockpile in the group is filtered out.

Recalculate the first group on table changes works, but, might be expensive? (It may be possible to minimize the amount of updates needed, given some effort)

@GoldenGnu GoldenGnu added bug Defect stockpile Stockpile Tool labels Sep 18, 2024
@GoldenGnu GoldenGnu self-assigned this Sep 18, 2024
@GoldenGnu GoldenGnu added the done This feature will be included in the next feature release label Oct 5, 2024
@GoldenGnu GoldenGnu removed their assignment Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect done This feature will be included in the next feature release stockpile Stockpile Tool
Projects
Status: ✅ 7.9.1
Development

No branches or pull requests

1 participant