Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Fix timezone issues #2203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Chart: Fix timezone issues #2203

wants to merge 1 commit into from

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix #2193

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: ebc229d
Status: ✅  Deploy successful!
Preview URL: https://a3ee4c23.gladys-plus.pages.dev
Branch Preview URL: https://fix-timezone-issue-device-fe.gladys-plus.pages.dev

View logs

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 20, 2025

#2953 Bundle Size — 10.41MiB (0%).

ebc229d(current) vs 04c1528 master#2952(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2953		      Baseline
#2952
No change  Initial JS 5.64MiB 5.64MiB
No change  Initial CSS 304.89KiB 304.89KiB
Change  Cache Invalidation 0% 54.07%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1511 1511
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2953		      Baseline
#2952
No change  JS 7.43MiB 7.43MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 321.79KiB 321.79KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.79KiB 17.79KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis report Branch fix-timezone-issue-device-featur... Project dashboard

Generated by RelativeCI Documentation Report issue

@Pierre-Gilles
Copy link
Contributor Author

@LM1LC3N7 I started a build on Docker tag: gladysassistant/gladys:fix-timezone-issue-device-feature

https://github.com/GladysAssistant/Gladys/actions/runs/12872235082

@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (6326203) to head (ebc229d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2203   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         876      876           
  Lines       14432    14436    +4     
=======================================
+ Hits        14221    14225    +4     
  Misses        211      211

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LM1LC3N7
Copy link
Contributor

Wow, 52min to build, it was long!
Just tried, and works like a charm! My "one hour" charts are back 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph : When loading a graph from a different timezone than Europe/Paris, the "1 hour" mode is always empty
2 participants
@Pierre-Gilles @LM1LC3N7