You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.
Based on this error I get when running GitBook 3.2.2:
Uncaught TypeError: Cannot read property 'top' of undefined
at a (theme.js:formatted:5276)
at HTMLLIElement.<anonymous> (theme.js:formatted:5315)
at Function.each (theme.js:formatted:784)
at de.fn.init.each (theme.js:formatted:694)
at HTMLDivElement.l (theme.js:formatted:5313)
at HTMLDivElement.dispatch (theme.js:formatted:2468)
at HTMLDivElement.m.handle (theme.js:formatted:2400)
I've tracked it down to be from an optimized version of the while loop in getElementTopPosition of src/js/theme/navigation.js where $parent (and therefore $el) could be null. Accordingly, in PR #51 I've done the following:
A null check to the while loop of getElementTopPosition
An empty jQuery element check to the while loop of getElementTopPosition
Sensible defaults should the call to $el.position().top in getElementTopPosition fail
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Based on this error I get when running GitBook 3.2.2:
I've tracked it down to be from an optimized version of the
while
loop ingetElementTopPosition
ofsrc/js/theme/navigation.js
where$parent
(and therefore$el
) could benull
. Accordingly, in PR #51 I've done the following:while
loop ofgetElementTopPosition
while
loop ofgetElementTopPosition
$el.position().top
ingetElementTopPosition
failThe text was updated successfully, but these errors were encountered: