You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
It's very hard to override Notification with your SDK. When I tried to override DefaultNotificationHandler and write my own handler with my own notification style and buttons, I cannot do it, because many methods there are internal or private, so I cannot for example override getIncomingCallNotification because it's private, and I cannot use your DefaultStreamIntentResolver because this is internal.
I report this as a bug, not feature, because I think that your intention was to let people using your SDK customizing notification look, style and behaviour. And indeed - it is possible, hovewer I need to write everything from scratch, and I love to reuse some code that you already wrote - such as DefaultStreamIntentResolver
SDK version
1.0.17
To Reproduce
Steps to reproduce the behavior: Try for example to modify incoming or outgoing notification text 😄
Expected behavior
Almost all internal and private methods in DefaultNotificationHandler should be protected or open, to be able to easily modify and customise notifications.
The text was updated successfully, but these errors were encountered:
Describe the bug
It's very hard to override Notification with your SDK. When I tried to override
DefaultNotificationHandler
and write my own handler with my own notification style and buttons, I cannot do it, because many methods there are internal or private, so I cannot for example overridegetIncomingCallNotification
because it's private, and I cannot use yourDefaultStreamIntentResolver
because this is internal.I report this as a bug, not feature, because I think that your intention was to let people using your SDK customizing notification look, style and behaviour. And indeed - it is possible, hovewer I need to write everything from scratch, and I love to reuse some code that you already wrote - such as
DefaultStreamIntentResolver
SDK version
To Reproduce
Steps to reproduce the behavior: Try for example to modify incoming or outgoing notification text 😄
Expected behavior
Almost all internal and private methods in
DefaultNotificationHandler
should be protected or open, to be able to easily modify and customise notifications.The text was updated successfully, but these errors were encountered: