Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you simplify overriding DefaultNotificationHandler to let customers create own Notification style and look #1214

Open
Miara opened this issue Oct 25, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@Miara
Copy link

Miara commented Oct 25, 2024

Describe the bug
It's very hard to override Notification with your SDK. When I tried to override DefaultNotificationHandler and write my own handler with my own notification style and buttons, I cannot do it, because many methods there are internal or private, so I cannot for example override getIncomingCallNotification because it's private, and I cannot use your DefaultStreamIntentResolver because this is internal.

I report this as a bug, not feature, because I think that your intention was to let people using your SDK customizing notification look, style and behaviour. And indeed - it is possible, hovewer I need to write everything from scratch, and I love to reuse some code that you already wrote - such as DefaultStreamIntentResolver

SDK version

  • 1.0.17

To Reproduce
Steps to reproduce the behavior: Try for example to modify incoming or outgoing notification text 😄

Expected behavior
Almost all internal and private methods in DefaultNotificationHandler should be protected or open, to be able to easily modify and customise notifications.

@Miara Miara added the bug Something isn't working label Oct 25, 2024
@aleksandar-apostolov
Copy link
Collaborator

Hey @Miara

We have added this to our backlog thou we cannot make any promises regarding priority or timeline.
Will keep you posted here.

Regards,
Alex

@aleksandar-apostolov aleksandar-apostolov added the enhancement New feature or request label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants