From 66acbb14d8361b2116d3a5d94609894a5ac70ddd Mon Sep 17 00:00:00 2001 From: Alexey Alter-Pesotskiy Date: Mon, 29 Jul 2024 12:58:15 +0100 Subject: [PATCH] Fix typo --- .github/workflows/performance-metrics.yml | 58 ------------------- .github/workflows/sdk-performance-metrics.yml | 58 +++++++++++++++++++ .github/workflows/sdk-size-metrics.yml | 4 +- fastlane/Fastfile | 2 +- 4 files changed, 61 insertions(+), 61 deletions(-) delete mode 100644 .github/workflows/performance-metrics.yml create mode 100644 .github/workflows/sdk-performance-metrics.yml diff --git a/.github/workflows/performance-metrics.yml b/.github/workflows/performance-metrics.yml deleted file mode 100644 index 94f9c056fc..0000000000 --- a/.github/workflows/performance-metrics.yml +++ /dev/null @@ -1,58 +0,0 @@ -# name: Metrics - -# on: -# schedule: -# # Runs "At 03:00 every night" -# - cron: '0 3 * * *' - -# pull_request: -# types: -# - opened -# - ready_for_review - -# workflow_dispatch: - -# env: -# HOMEBREW_NO_INSTALL_CLEANUP: 1 # Disable cleanup for homebrew, we don't need it on CI - -# jobs: -# performance: -# name: Performance -# runs-on: macos-14 -# env: -# GITHUB_TOKEN: '${{ secrets.CI_BOT_GITHUB_TOKEN }}' -# steps: -# - name: Install Bot SSH Key -# if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} -# uses: webfactory/ssh-agent@v0.7.0 -# with: -# ssh-private-key: ${{ secrets.BOT_SSH_PRIVATE_KEY }} - -# - uses: actions/checkout@v3.1.0 -# if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} -# with: -# fetch-depth: 0 # to fetch git tags - -# - uses: ./.github/actions/bootstrap -# if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} -# env: -# GOOGLE_APPLICATION_CREDENTIALS: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }} -# INSTALL_GCLOUD: true - -# - name: Run XCMetrics -# if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} -# run: bundle exec fastlane xcmetrics -# timeout-minutes: 120 -# env: -# GITHUB_PR_NUM: ${{ github.event.pull_request.number }} -# BRANCH_NAME: ${{ github.event.pull_request.head.ref }} -# MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }} -# APPSTORE_API_KEY: ${{ secrets.APPSTORE_API_KEY }} - -# - uses: actions/upload-artifact@v4 -# if: failure() -# with: -# name: Test Data -# path: | -# derived_data/Build/Products/xcodebuild_output.log -# fastlane/performance/stream-chat-swift.json diff --git a/.github/workflows/sdk-performance-metrics.yml b/.github/workflows/sdk-performance-metrics.yml new file mode 100644 index 0000000000..808754a3f3 --- /dev/null +++ b/.github/workflows/sdk-performance-metrics.yml @@ -0,0 +1,58 @@ +name: SDK Performance + +on: + schedule: + # Runs "At 03:00 every night" + - cron: '0 3 * * *' + + pull_request: + types: + - opened + - ready_for_review + + workflow_dispatch: + +env: + HOMEBREW_NO_INSTALL_CLEANUP: 1 # Disable cleanup for homebrew, we don't need it on CI + +jobs: + performance: + name: Metrics + runs-on: macos-14 + env: + GITHUB_TOKEN: '${{ secrets.CI_BOT_GITHUB_TOKEN }}' + steps: + - name: Install Bot SSH Key + if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} + uses: webfactory/ssh-agent@v0.7.0 + with: + ssh-private-key: ${{ secrets.BOT_SSH_PRIVATE_KEY }} + + # - uses: actions/checkout@v3.1.0 + # if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} + # with: + # fetch-depth: 0 # to fetch git tags + + # - uses: ./.github/actions/bootstrap + # if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} + # env: + # GOOGLE_APPLICATION_CREDENTIALS: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }} + # INSTALL_GCLOUD: true + + # - name: Run XCMetrics + # if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }} + # run: bundle exec fastlane xcmetrics + # timeout-minutes: 120 + # env: + # GITHUB_PR_NUM: ${{ github.event.pull_request.number }} + # BRANCH_NAME: ${{ github.event.pull_request.head.ref }} + # MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }} + # APPSTORE_API_KEY: ${{ secrets.APPSTORE_API_KEY }} + + # - uses: actions/upload-artifact@v4 + # if: failure() + # with: + # name: Test Data + # path: | + # derived_data/Build/Products/xcodebuild_output.log + # fastlane/performance/stream-chat-swift.json diff --git a/.github/workflows/sdk-size-metrics.yml b/.github/workflows/sdk-size-metrics.yml index 08c8429d4e..c7e6af98ca 100644 --- a/.github/workflows/sdk-size-metrics.yml +++ b/.github/workflows/sdk-size-metrics.yml @@ -1,4 +1,4 @@ -name: Metrics +name: SDK Size on: pull_request: @@ -14,7 +14,7 @@ env: jobs: sdk_size: - name: SDK Size + name: Metrics runs-on: macos-14 env: GITHUB_TOKEN: '${{ secrets.CI_BOT_GITHUB_TOKEN }}' diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 273150ec90..b5a353db43 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -934,7 +934,7 @@ end private_lane :create_pr_comment do |options| if is_ci && !options[:pr_num].to_s.empty? - last_comment = sh("gh pr view #{options[:pr_num]} --json comments --jq '.comments | map(select(.author.login == \"Stream-iOS-Bot\")) | last") + last_comment = sh("gh pr view #{options[:pr_num]} --json comments --jq '.comments | map(select(.author.login == \"Stream-iOS-Bot\")) | last'") edit_last_comment = last_comment.include?(options[:edit_last_comment_with_text]) ? '--edit-last' : '' sh("gh pr comment #{options[:pr_num]} #{edit_last_comment} -b '#{options[:text]}'") end