Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser out of date message for react dash #2136

Closed
kimwdavidson opened this issue Sep 26, 2017 · 4 comments
Closed

Browser out of date message for react dash #2136

kimwdavidson opened this issue Sep 26, 2017 · 4 comments

Comments

@kimwdavidson
Copy link

kimwdavidson commented Sep 26, 2017

User Story:

As a site visitor, when I visit a react dashboard, if my older browser is not compatible with react dash, I should see a message informing me that my browser might be out of date, and I should update it, so that I know why I can't see dashboards.

@JayDarnell
Copy link

I'm putting an estimate of a day on this ticket as a bit of a blind guess. I've done some preliminary research into how we might figure out what browser versions are supported:

https://reactjs.org/docs/react-dom.html#browser-support

http://kangax.github.io/compat-table/es5/

There may be more research to be done but assuming these resources are a step in the right direction it should be a matter of checking the browser version against the compatibility table in the link above and updating the DOM with a notification if an unsupported browser is detected.

@JayDarnell
Copy link

@iris-i
Copy link

iris-i commented Nov 1, 2017

React component for browser detection: https://github.com/mbasso/react-browser-detection

@kimwdavidson
Copy link
Author

This issue was moved to GetDKAN/dkan_dash#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants