Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counts of resources by format to search results page #69

Open
1 of 2 tasks
kimwdavidson opened this issue Mar 17, 2021 · 6 comments
Open
1 of 2 tasks

Add counts of resources by format to search results page #69

kimwdavidson opened this issue Mar 17, 2021 · 6 comments

Comments

@kimwdavidson
Copy link

kimwdavidson commented Mar 17, 2021

Background

Currently, the search results page shows dataset results with the resources in them by format. These resources are represented by icons showing the format. Currently, the number of icons represents the number for resources, for example, when there are three CSVs in the dataset, there are three CSV icons. This is visually confusing, redundant, and cluttered. We'd like instead for it look more like the DKAN1 implementation, where there is a single icon, and if more than one resource of a type exists, then we see the number with an x before the icon. for example: 3x(CSV icon)

Acceptance Criteria

  • When I search for datasets

  • And I see the search results page

  • And there is a dataset with multiple resources of the same format

  • Then I see that represented as (number)x(format icon)

  • Working downstream on Marine Scotland

  • Working upstream (1.9.x branch) : https://demo.getdkan.org/search/

##Estimate: 3

@alexiscott
Copy link
Contributor

@dharizza the change got merged upstream, which I have confirmed. If you have a chance to checkout https://github.com/NuCivic/data-marine-scotland/pull/24 that would be great?
Thanks!

@alexiscott alexiscott assigned dharizza and unassigned alexiscott Mar 18, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

Hi @dharizza Could you please review this ticket or let me know when you're planning on reviewing it? Thanks!

@dharizza
Copy link
Contributor

Sorry haven't been able to review this. If it is not ready when I come back, then I'll check it out.

@ghost ghost assigned rhabbachi and unassigned dharizza Mar 29, 2021
@rhabbachi rhabbachi assigned alexiscott and unassigned rhabbachi Apr 5, 2021
@rhabbachi
Copy link
Contributor

@alexiscott to confirm how to handle this for the 2.x version.

@ghost
Copy link

ghost commented Apr 7, 2021

Moved to the backlog because we need to check with Alex if the 2.0 implementation aspect of this ticket needs to be tracked in the Support or in the Product board.

@alexiscott
Copy link
Contributor

@cmugisha Again, as I will not be on the project this coming month, it probably makes sense that @dgading suggests the best place for 2.0 tickets to reside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants