Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use grid system from USWDS #56

Open
6 tasks done
dgading opened this issue Feb 18, 2021 · 1 comment · Fixed by #57
Open
6 tasks done

Update to use grid system from USWDS #56

dgading opened this issue Feb 18, 2021 · 1 comment · Fixed by #57
Assignees
@dgading @alexiscott
Labels
frontend
Milestone
v2.0.0

Comments

@dgading
Copy link
Member

dgading commented Feb 18, 2021 •
edited by alexiscott
Loading

In the 2.0.0 branch, all of the current style imports have been removed. The new site's grid system should be built using the USWDS layout classes. The pages will still be mostly unstyled but as we replace components in the component library they will appear correctly on each page.
https://designsystem.digital.gov/utilities/layout-grid/

Acceptance Criteria
The following pages of the site are using the USDWS grid system with mobile and desktop layouts:

  • Home
  • Search
  • Publishers
  • About
  • API
  • Dataset Page
@dgading dgading added this to the v2.0.0 milestone Feb 18, 2021
@alexiscott alexiscott linked a pull request Feb 23, 2021 that will close this issue
Update to use grid system from USWDS #57
Merged
@alexiscott
Copy link
Contributor

Ready for code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgading dgading

@alexiscott alexiscott

Labels
frontend
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Update to use grid system from USWDS GetDKAN/data-catalog-app
2 participants
@dgading @alexiscott