From 2b303abfdc6014120e2df0f900c9891cfab08b9a Mon Sep 17 00:00:00 2001 From: Florian Leimer Date: Fri, 10 Jan 2025 11:25:35 +0100 Subject: [PATCH 1/2] Fix PHP 8.4 deprecation notice for implicitly marking parameter as nullable --- Classes/CodeGenerator/TcaCodeGenerator.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/CodeGenerator/TcaCodeGenerator.php b/Classes/CodeGenerator/TcaCodeGenerator.php index 57b14ef0..fabb63b7 100644 --- a/Classes/CodeGenerator/TcaCodeGenerator.php +++ b/Classes/CodeGenerator/TcaCodeGenerator.php @@ -52,7 +52,7 @@ public function __construct( /** * Generates and sets the correct tca for all the inline fields */ - public function setInlineTca(TableDefinitionCollection $tableDefinitionCollection = null): void + public function setInlineTca(?TableDefinitionCollection $tableDefinitionCollection = null): void { $this->tableDefinitionCollection = $tableDefinitionCollection ?? $this->tableDefinitionCollection; foreach ($this->tableDefinitionCollection as $tableDefinition) { From 7975b14dfc5749a0eefe002d7fb5dc5a7eff68d3 Mon Sep 17 00:00:00 2001 From: Nikita Hovratov Date: Fri, 10 Jan 2025 11:37:22 +0100 Subject: [PATCH 2/2] [TASK] Run phpstan with PHP 8.4 --- .github/workflows/tests.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index f528670c..6b19122e 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -92,14 +92,14 @@ jobs: run: Build/Scripts/runTests.sh -s unit -p ${{ matrix.php }} PHPStan: - name: PHPStan TYPO3 13.4 PHP 8.2 + name: PHPStan TYPO3 13.4 PHP 8.4 runs-on: ubuntu-latest steps: - name: Setup PHP uses: shivammathur/setup-php@v2 with: - php-version: 8.2 + php-version: 8.4 - uses: actions/checkout@v3