Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refactor orbital module #348

Open
mcgarth opened this issue Jul 23, 2021 · 0 comments
Open

Review and refactor orbital module #348

mcgarth opened this issue Jul 23, 2021 · 0 comments

Comments

@mcgarth
Copy link
Contributor

mcgarth commented Jul 23, 2021

In light of the big changes to the Orbital module in #303, review and refactor the module. Here are some considerations:

  • communicate to users when is it worth using the orbital correction (what sensor, size of imaged area etc).
  • more testing of the use of scale factor in the DM for network method and refine the default value if necessary.
  • refactor the flow of the module and re-use functionality for both independent and network methods where possible (e.g. multi-looking)
  • reconsider the need for the application of the offset as the median of the image during the orbital module (pyrate.core.ref_phs_est can be ran before and/or afterwards to have the same impact on the data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant