Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the persons left #53

Open
nyampire opened this issue Jul 2, 2021 · 3 comments · May be fixed by #63
Open

Remove the persons left #53

nyampire opened this issue Jul 2, 2021 · 3 comments · May be fixed by #63
Assignees

Comments

@nyampire
Copy link

nyampire commented Jul 2, 2021

Is your feature request related to a problem? Please describe.
Daily notification remains for the members who left Georepublic already. (thibault, iosefa, leo and marc)

Describe the solution you'd like
Change setting? I cannot find the list of username.

Describe alternatives you've considered
none

Additional context
none

@sanak sanak self-assigned this Jan 4, 2023
@sanak
Copy link
Member

sanak commented Jan 4, 2023

The list seems to come from Google Spreadsheet's each members sheet.

I changed the left members sheet's A2 cell DayOff value from default 土,日 to 全部 and it should work.
slack-timesheet-each-members-header2

Let's see the result once, then remove the sheets after backup.

@sanak
Copy link
Member

sanak commented Jan 5, 2023

Hmm... The following doesn't work...

I changed the left members sheet's A2 cell DayOff value from default 土,日 to 全部 and it should work.

I will check the cause, later.

@sanak
Copy link
Member

sanak commented Mar 1, 2023

Hmm... The following doesn't work...

I changed the left members sheet's A2 cell DayOff value from default 土,日 to 全部 and it should work.

I will check the cause, later.

There is no 全部 detection code, and supporting it may become a bit tricky code in the following parseWday method, so I will remove アカウント停止のためには「全部」と入れてください。 sentence which has not been implemented yet.
https://github.com/Georepublic/miyamoto/blob/master/scripts/date_utils.js#L181-L190

  // 曜日を解析
  DateUtils.parseWday = function(str) {
    str = String(str).replace(/曜日/g, '');
    var result = [];
    var wdays = [/(sun|日)/i, /(mon|月)/i, /(tue|火)/i, /(wed|水)/i, /(thu|木)/i, /(fri|金)/i, /(sat|土)/i];
    for(var i=0; i<wdays.length; ++i) {
      if(str.match(wdays[i])) result.push(i);
    }
    return result;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants