You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the published ADR 2.0.0 this results in no contrast issues, but highlightjs will wrongly auto detected this as JavaScript, so https: as label and the following // as comment:
There is no contrast issue in ADR 2.0.0, but in ADR 2.0.1 is probably generated with a newer highlightjs version, since the generated HTML now also has the hljs-attr styling class:
BTW If your unfamiliar, see the Firefox Developer Tools, Accessibility tab and check for contrast:
Also see MDN about WCAG ratings for more information.
The text was updated successfully, but these errors were encountered:
Currently
<pre>URI</pre>
is used, see DesignRules.md#L51:In the published ADR 2.0.0 this results in no contrast issues, but highlightjs will wrongly auto detected this as JavaScript, so
https:
as label and the following//
as comment:There is no contrast issue in ADR 2.0.0, but in ADR 2.0.1 is probably generated with a newer highlightjs version, since the generated HTML now also has the
hljs-attr
styling class:Together with a color change, the contrast of the 'comment part' of the URI against the background is 2.32, which is too low for WCAG AA rating.
Maybe the
nohighlight
class should be used? E.g.BTW If your unfamiliar, see the Firefox Developer Tools, Accessibility tab and check for contrast:
Also see MDN about WCAG ratings for more information.
The text was updated successfully, but these errors were encountered: