-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inefficient handling of burn in phase in sampling functions #180
Comments
I would like to work on this issue |
I'd like to work on this issue if it's still open! |
@TolisChal Is this still open? I would love to work on it |
@nanu1605 please feel free to open a PR. |
|
@ha-rahman there are no assignments on issues, everyone is free to start working on a issue. The first pull request that is reviewed and approved will be merged. |
Thank you.
…On Mon, 13 Mar 2023, 17:01 Vissarion Fisikopoulos, ***@***.***> wrote:
@ha-rahman <https://github.com/ha-rahman> there are no assignments on
issues, everyone is free to start working on a issue. The first pull
request that is reviewed and approved will be merged.
—
Reply to this email directly, view it on GitHub
<#180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVNJLFOFDEEWDL32YF66GQLW34AS5ANCNFSM5FEROUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
hey , can i work on this? |
@KhushV25 sure, please go ahead and submit a PR. |
can i submit a PR? |
hey , can i work on this ? is this still open ? |
In header
include/sampling.hpp
the sampling functions do not handle the burn in phase efficiently.They store the points of burn in phase and then they delete them.
RandomPointGenerator::apply(P, p, c, a, eta, nburns, walk_len, randPoints, push_back_policy, rng); randPoints.clear();
We need a new function to perform the burn in phase efficiently.
The text was updated successfully, but these errors were encountered: