-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added table of content to open layer details in map view. #1661
base: master
Are you sure you want to change the base?
Conversation
@ahmdthr the PR still is marked as draft .. if this is intended, though, please ignore my comment |
@ahmdthr this one would have to be aligned to the latest changes of linked resources |
@ahmdthr Kindly resolve the conflicts and align the code changes with the latest changes in master. Thanks! |
I've tested the PR locally. The idea is good and it's really useful, but I have a few concerns:
I think this could be improved if the following is implemented:
@gannebamm @ahmdthr if you agree I would consider these improvements before merging it. In that case the PR should be marked as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #1661 (comment)
@giohappy Thank you very much for your comments. The only reason a new request was being made was because the linked resources were not included in the batch request. Now with recent changes, it is no longer necessary to sent a request to fetch linked resources. I am currently working on it and expect the final version of the PR shortly. |
…er of requests for info button on maps page.
…resources for info button on TOC.
The info button for layers on the maps page now fetches all data including linked resources with a single call. Additionally, the linked resources are stored in state such that re-fetching is not necessary when re selecting one layer again. |
Resolves #1660
Resolves #1616
A new button to view layer details is added on the map view.