Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ex52: figure is loaded externally #8489

Open
anbj opened this issue May 16, 2024 · 6 comments
Open

Ex52: figure is loaded externally #8489

anbj opened this issue May 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@anbj
Copy link
Contributor

anbj commented May 16, 2024

I've built the docs locally, and ex52 actually loads the image from https://user-images.githubusercontent.com/14077947/123172626-62ca6880-d44b-11eb-8d91-21e448930460.png.

Deliberate?

I would expect it to load a locally generated version/dvc version, so that you don't need an internet connection to see it.

@anbj anbj added the bug Something isn't working label May 16, 2024
@seisman
Copy link
Member

seisman commented May 17, 2024

You're talking about ex53, right?

The example ex53 was initially added in #5336. We didn't add the ex53.ps file into the repository because, the PS file is too large (~10 MB) and at that time we haven't set up DVC yet.

But now, since we already have DVC set up, I think it's time to add the PS image to DVC.

@anbj
Copy link
Contributor Author

anbj commented May 17, 2024

Yes, Ex53! Sorry.

@seisman
Copy link
Member

seisman commented May 23, 2024

Add the ~10 MB ex53.ps to DVC is fine, but the problem is, when we make the GMT release, the large PS file is also included in the GMT tarball, which can significant increase the size of the tarball.

@anbj
Copy link
Contributor Author

anbj commented May 23, 2024

Ok. So not do it and close? 10 MB is alot for one figure.

@seisman
Copy link
Member

seisman commented May 23, 2024

I'm considering whether we should not include the original PS files in tarballs. If not, then the 10 MB PS file won't be a problem.

@joa-quim
Copy link
Member

I agree we shouldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants