-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ex52: figure is loaded externally #8489
Comments
You're talking about ex53, right? The example ex53 was initially added in #5336. We didn't add the ex53.ps file into the repository because, the PS file is too large (~10 MB) and at that time we haven't set up DVC yet. But now, since we already have DVC set up, I think it's time to add the PS image to DVC. |
Yes, Ex53! Sorry. |
Add the ~10 MB ex53.ps to DVC is fine, but the problem is, when we make the GMT release, the large PS file is also included in the GMT tarball, which can significant increase the size of the tarball. |
Ok. So not do it and close? 10 MB is alot for one figure. |
I'm considering whether we should not include the original PS files in tarballs. If not, then the 10 MB PS file won't be a problem. |
I agree we shouldn't. |
I've built the docs locally, and ex52 actually loads the image from https://user-images.githubusercontent.com/14077947/123172626-62ca6880-d44b-11eb-8d91-21e448930460.png.
Deliberate?
I would expect it to load a locally generated version/dvc version, so that you don't need an internet connection to see it.
The text was updated successfully, but these errors were encountered: