Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on categories page / voting power box #42

Closed
2 tasks done
MoeNick opened this issue Oct 24, 2024 · 12 comments
Closed
2 tasks done

Improvements on categories page / voting power box #42

MoeNick opened this issue Oct 24, 2024 · 12 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Oct 24, 2024

@MoeNick MoeNick converted this from a draft issue Oct 24, 2024
@MoeNick MoeNick added P2 ordinary flow of work P1 finish this task to unblock someone else, required to be done before other things and removed P2 ordinary flow of work P1 finish this task to unblock someone else, required to be done before other things labels Oct 24, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 27, 2024

Hey @HrithikSampson can you jump into this one, please?

@MoeNick MoeNick moved this from Todo to In Progress in Pairwise RF6 Oct 27, 2024
@maryjaf
Copy link
Collaborator

maryjaf commented Oct 27, 2024

  • when I revoke the delegation of budget I should refresh the page to see the changes
Screen.Recording.2024-10-27.at.3.05.51.PM.mov

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

It shouldn't be shown that "2 people delegated to you" instead of " some one delegated to you"
@HrithikSampson @MoeNick
image

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

I think it needs a backend service @mmahdigh

@HrithikSampson
Copy link
Collaborator

@maryjaf , I think the number of delegates is integrated

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

It seems it hasn't been fixed yet @HrithikSampson

Screen.Recording.2024-10-28.at.6.33.45.PM.mov

image

@HrithikSampson
Copy link
Collaborator

@maryjaf ,I think it will work now but I am not sure since I cant delegate to myself now

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

I see 2 and 4 people, I'm not sure which is correct

Screenshot 2024-10-28 at 8 39 46 PM Screenshot 2024-10-28 at 8 40 16 PM

wallet account: 0x523E41A134Ab0999F2dC844eA02d9b53cC28fD1a
@HrithikSampson

@maryjaf maryjaf mentioned this issue Oct 28, 2024
8 tasks
@HrithikSampson
Copy link
Collaborator

HrithikSampson commented Oct 28, 2024

@maryjaf 2 people delegated from budget i think the remaining two were delegators from the other collections which is shown voted. I am a little confused and not sure whether this is right

@MoeNick @mmahdigh

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

two were delegators from the other collections which is shown voted. I am a little confused and not sure whether this is right

It should be shown delegated I think not voted, am I right? @mmahdigh

@HrithikSampson
Copy link
Collaborator

HrithikSampson commented Oct 28, 2024

{
    "fromYou": {
        "collections": [],
        "budget": null
    },
    "toYou": {
        "uniqueDelegators": 4,
        "uniqueCollectionDelegators": 4,
        "uniqueBudgetDelegators": 2,
        "collections": [
            {
                "collectionId": 1,
                "metadata": {
                    "username": "maryjaf",
                    "profileUrl": "https://imagedelivery.net/BXluQx4ige9GuW0Ia56BHw/e7cb60bc-f30f-4cb9-cd60-d414cd4b8900/rectcrop3"
                }
            },
            {
                "collectionId": 2,
                "metadata": {
                    "username": "maryjaf",
                    "profileUrl": "https://imagedelivery.net/BXluQx4ige9GuW0Ia56BHw/e7cb60bc-f30f-4cb9-cd60-d414cd4b8900/rectcrop3"
                }
            },
            {
                "collectionId": 3,
                "metadata": {
                    "username": "maryjaf",
                    "profileUrl": "https://imagedelivery.net/BXluQx4ige9GuW0Ia56BHw/e7cb60bc-f30f-4cb9-cd60-d414cd4b8900/rectcrop3"
                }
            },
            {
                "collectionId": 2,
                "metadata": {
                    "username": "maryjaf",
                    "profileUrl": "https://imagedelivery.net/BXluQx4ige9GuW0Ia56BHw/e7cb60bc-f30f-4cb9-cd60-d414cd4b8900/rectcrop3"
                }
            }
        ],
        "budget": [
            {
                "metadata": {
                    "username": "maryjaf",
                    "profileUrl": "https://imagedelivery.net/BXluQx4ige9GuW0Ia56BHw/e7cb60bc-f30f-4cb9-cd60-d414cd4b8900/rectcrop3"
                }
            },
            {
                "metadata": {
                    "username": "maryjaf",
                    "profileUrl": "https://imagedelivery.net/BXluQx4ige9GuW0Ia56BHw/e7cb60bc-f30f-4cb9-cd60-d414cd4b8900/rectcrop3"
                }
            }
        ]
    }
}

the unique number of delegators from the api is 4 but we aren't showing the collections delegation

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 29, 2024

@mmahdigh I appreciate it if you can take a look.

@MoeNick MoeNick moved this from On Staging / QA to Approved by QA in Pairwise RF6 Oct 29, 2024
@MoeNick MoeNick closed this as completed by moving to Approved by QA in Pairwise RF6 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

3 participants