Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories View for Badgeholders #37

Open
4 tasks done
Tracked by #2
MoeNick opened this issue Oct 23, 2024 · 14 comments
Open
4 tasks done
Tracked by #2

Categories View for Badgeholders #37

MoeNick opened this issue Oct 23, 2024 · 14 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Oct 23, 2024

As a bagholder, I wanted my assigned category to be distinguished, so I could more easily select and vote.

Design:

https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6--%3E-Voting-App?node-id=1763-120069&t=ouQwybKxViyhOLEW-4
Image

Success Criteria

  • 0. This will be visible to only Badgholders (both guest votes and citizens) you can detect whether user is badgholder or not from the SIWE login done in login flow, the jwt token will have this data.
  • 1. From SIWE login we get the users category (assigned category) - this category plus the budget category should only have the Vote button enabled, they could have a delegated to you badge as well.
  • 2. Other categories will have the vote button disabled.
  • other delegation and voting functionalities should be the same.
@MoeNick MoeNick converted this from a draft issue Oct 23, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 23, 2024

Just a new use-case added to this view today @Meriem-BM

tagging @mmahdigh to be in the loop

@Meriem-BM
Copy link
Collaborator

Hey @MoeNick for Update Ballot can you remind me when should it be disabled?

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

Hey for Ballot

  • if badgholder: disabled until the assigned category is voted
  • If not baddgholder: always enabled. (Mahdi handled it by a modal, if assigned category is not voted)
    @Meriem-BM

@Meriem-BM
Copy link
Collaborator

You can test this @maryjaf, @MoeNick except this, still didn't add

  • if badgholder: disabled until the assigned category is voted
  • If not baddgholder: always enabled. (Mahdi handled it by a modal, if assigned category is not voted)
    @Meriem-BM

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

@maryjaf you're nt a badgholder. try to decode here https://www.jstoolset.com/jwt
image

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

@maryjaf you're nt a badgholder. try to decode here https://www.jstoolset.com/jwt image

image

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

maybe it's a test badge, but what I mean is having it in your jwt token, because we only want this view for OP badgholders based on Agora source, they should be able to update ballot so it's the only source of truth.

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

So please set for this account the badge holder @MoeNick @mmahdigh

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

@maryjaf please test with this address: 0xA1179f64638adb613DDAAc32D918EB6BEB824104
it has badgholder:true on Agora

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

Success Criteria

  • 0. This will be visible to only Badgholders (both guest votes and citizens) you can detect whether user is badgholder or not from the SIWE login done in login flow, the jwt token will have this data.
  • 1. From SIWE login we get the users category (assigned category) - this category plus the budget category should only have the Vote button enabled, they could have a delegated to you badge as well.
  • 2. Other categories will have the vote button disabled.
  • other delegation and voting functionalities should be the same.

this ACs have been passed

the below ACs remain

Hey for Ballot

  • if badgholder: disabled until the assigned category is voted
  • If not baddgholder: always enabled. (Mahdi handled it by a modal, if assigned category is not voted)
    @Meriem-BM

@Meriem-BM
Copy link
Collaborator

Meriem-BM commented Oct 28, 2024

Success Criteria

  • 0. This will be visible to only Badgholders (both guest votes and citizens) you can detect whether user is badgholder or not from the SIWE login done in login flow, the jwt token will have this data.
  • 1. From SIWE login we get the users category (assigned category) - this category plus the budget category should only have the Vote button enabled, they could have a delegated to you badge as well.
  • 2. Other categories will have the vote button disabled.
  • other delegation and voting functionalities should be the same.

this ACs have been passed

the below ACs remain

Hey for Ballot

  • if badgholder: disabled until the assigned category is voted
  • If not baddgholder: always enabled. (Mahdi handled it by a modal, if assigned category is not voted)

@Meriem-BM

Can you test those too, I added in recent merge, thanks

@maryjaf maryjaf moved this from In Progress to On Staging / QA in Pairwise RF6 Oct 28, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 29, 2024

@MoeNick MoeNick moved this from Approved by QA to On Staging / QA in Pairwise RF6 Oct 29, 2024
@MoeNick MoeNick moved this from On Staging / QA to In Progress in Pairwise RF6 Oct 29, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 29, 2024

is this ready for test again? @Meriem-BM ?
FYI: @maryjaf

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 29, 2024

could you please remove the vote of this user 0xA1179f64638adb613DDAAc32D918EB6BEB824104 for testing the remaining ACs? @Meriem-BM @mmahdigh

@maryjaf maryjaf moved this from On Staging / QA to Approved by QA in Pairwise RF6 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

3 participants