Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ballot flow #15

Open
6 tasks done
Tracked by #2
MoeNick opened this issue Oct 15, 2024 · 9 comments
Open
6 tasks done
Tracked by #2

Update ballot flow #15

MoeNick opened this issue Oct 15, 2024 · 9 comments
Assignees

Comments

@MoeNick
Copy link
Contributor

MoeNick commented Oct 15, 2024

As a badgeholder and as a guest voter, I want to be able to update my ballot on the official voting app UI.

Design

https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6--%3E-Voting-App?node-id=1175-36554&t=YULRHcxIjN0cH8Gc-4

Acceptance Criteria

  • Making sure the user is signed in with Agora SIWE and has the token, the user did it when connecting to the app in the first place, but if it's missing now by any chance, we have to ask for sign-in again.
  • making sure the category that has been assigned to the user (decoded from Agora JWT token) has voted status. if not showing the Connot update ballot with this copy in the design
  • making sure the update was successful in the Agora Voting App when we show the success modal.
  • In the success modal, by clicking on Send feedback we will open a Google form link. Questionnaire google form #22 - Here is the link: https://docs.google.com/forms/d/1n3Dwq2WoPTX8vtsGT_GQ2FsyQ6TIUabXJgYsYzVUK4o/edit
  • If the user encounters a problem by updating the ballot, we show the update ballot error modal and report an issue will open a new tab to create a new issue with this template.
  • Loading modal should be shown when submitting.
@MoeNick MoeNick changed the title 7- Update ballot CTA. 7- Update ballot flow. Oct 15, 2024
@MoeNick MoeNick changed the title 7- Update ballot flow. Update ballot flow Oct 15, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 17, 2024

@mmahdigh @Meriem-BM this one is ready to go.

@MoeNick MoeNick mentioned this issue Oct 17, 2024
1 task
@mmahdigh mmahdigh self-assigned this Oct 21, 2024
@mmahdigh mmahdigh mentioned this issue Oct 26, 2024
@MoeNick MoeNick moved this from In Progress to On Staging / QA in Pairwise RF6 Oct 27, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 27, 2024

@maryjaf to test.

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

  • 1- There is a problem in showing "important notice" modal
Screen.Recording.2024-10-28.at.10.14.58.AM.mov
  • 2- in this modal, when the confirmation text isn't marked "Update my ballot" button should be show ? @MoeNick

Image

@mmahdigh

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

  • 3- by tapping on view my ballot I got 404 error

Image

@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

  • 1- There is a problem in showing "important notice" modal

Screen.Recording.2024-10-28.at.10.14.58.AM.mov

  • 2- in this modal, when the confirmation text isn't marked "Update my ballot" button should be show ? @MoeNick

Image

@mmahdigh

For 2- it's disabled and when the user checks it it will be enabled AND IT WILL HAVE ANOTHER FEEDBACK BUTTON -link in the context of issue opens in a new tab,
image

@GeneralMagicio GeneralMagicio deleted a comment from maryjaf Oct 28, 2024
@MoeNick
Copy link
Contributor Author

MoeNick commented Oct 28, 2024

  • 3- by tapping on view my ballot I got 404 error

Image

For 3- link is https://develop-op-rf-6.up.railway.app/ballot for staging, which opens in a new tab.
(Reminder fro us we have to change it for prod later)

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

  • 4-when the category is delegated to another user by tapping on update ballot the below modal is shown
    the copy should be changed :

You delegated voting for {category name} to someone else. If you want to rank this category and update ballot, revoke your delegation first.
@mmahdigh

Screen.Recording.2024-10-28.at.11.47.47.AM.mov

@mmahdigh mmahdigh mentioned this issue Oct 28, 2024
@mmahdigh
Copy link
Collaborator

The reported issues should be fixed. Please retest. @maryjaf

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 28, 2024

  • 4-when the category is delegated to another user by tapping on update ballot the below modal is shown
    the copy should be changed :

You delegated voting for {category name} to someone else. If you want to rank this category and update ballot, revoke your delegation first.

Fixed
image

@maryjaf maryjaf moved this from On Staging / QA to Approved by QA in Pairwise RF6 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged on Production
Development

No branches or pull requests

3 participants