From 53016575c271be86134dee86737c81e605fadeb2 Mon Sep 17 00:00:00 2001 From: Alexander Taepper Date: Thu, 1 Feb 2024 09:22:18 +0100 Subject: [PATCH] refactor: minor edits for linter and compile warnings in release mode --- src/silo/common/data_version.test.cpp | 2 +- src/silo/query_engine/actions/fasta.cpp | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/silo/common/data_version.test.cpp b/src/silo/common/data_version.test.cpp index fe86ebb0a..5153dc0f2 100644 --- a/src/silo/common/data_version.test.cpp +++ b/src/silo/common/data_version.test.cpp @@ -6,7 +6,7 @@ using silo::DataVersion; TEST(DataVersion, shouldMineDataVersionFromUnixTime) { const auto mined_version = DataVersion::mineDataVersion(); - EXPECT_EQ(mined_version.toString().size(), 10); + EXPECT_EQ(mined_version.toString().size(), 10UL); EXPECT_EQ(mined_version.toString()[0], '1'); } diff --git a/src/silo/query_engine/actions/fasta.cpp b/src/silo/query_engine/actions/fasta.cpp index 240423209..2ba9fccb0 100644 --- a/src/silo/query_engine/actions/fasta.cpp +++ b/src/silo/query_engine/actions/fasta.cpp @@ -118,7 +118,6 @@ void addSequencesFromResultTableToJson( auto current_key = table_reader.next(genome_buffer); assert(current_key.has_value()); if (genome_buffer.has_value()) { - // NOLINTNEXTLINE(bugprone-unchecked-optional-access) results.query_result.at(idx).fields.emplace(sequence_name, *genome_buffer); } else { results.query_result.at(idx).fields.emplace(sequence_name, std::nullopt);