Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert wavelength units when opening a file (or check units in DRAGONS) #450

Open
chris-simpson opened this issue Apr 16, 2024 · 0 comments

Comments

@chris-simpson
Copy link
Contributor

When astrodata reads a FITS file with a wavelength axis, the units (from CUNITj) are stored but not changed. However, DRAGONS assumes that the units of wavelength axes are nm, without checking.

So we have to implement one of two things:

  1. Convert units at read time to nm
  2. Wherever a wavelength is determined from the WCS, its units have to be checked and converted to nm if necessary

Clearly 1 is easiest; 2 is a pain (which is why we didn't do this originally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant