Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate warnings correctly #430

Open
KathleenLabrie opened this issue Mar 30, 2023 · 0 comments
Open

Fix duplicate warnings correctly #430

KathleenLabrie opened this issue Mar 30, 2023 · 0 comments
Labels
enhancement Performance or usage improvement severity-routine Needs to be fixed urgency-medium Somewhat normal urgency

Comments

@KathleenLabrie
Copy link
Contributor

Currently there is a quick fix in gempy/utils/logutils.py where we just blanket-filter the duplicate warnings: add_filter(DuplicateWarningFilter, log)

We need to find a better solution.

From Chris:

IIRC, we couldn't get the filter to work exactly how we wanted (if the final warning is repeated multiple times it doesn't announce that, because the "last warning was repeated N times" message only appears when a new warning is logged) and we were going to try to work out how to get the desired behaviour.

The biggest offender is the "Unmasking all points" message.

@KathleenLabrie KathleenLabrie added enhancement Performance or usage improvement severity-routine Needs to be fixed urgency-medium Somewhat normal urgency labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Performance or usage improvement severity-routine Needs to be fixed urgency-medium Somewhat normal urgency
Projects
None yet
Development

No branches or pull requests

1 participant