Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify checking if config has changed #1685

Closed
koebi opened this issue Feb 13, 2024 · 0 comments · Fixed by #1687
Closed

Simplify checking if config has changed #1685

koebi opened this issue Feb 13, 2024 · 0 comments · Fixed by #1687
Milestone

Comments

@koebi
Copy link
Collaborator

koebi commented Feb 13, 2024

The workflow currently always checks out the repo and does some stuff before checking if the config has changed:

- name: Check with git if ors-api/ors-config.yml has changed

This could be done quicker and easier via the paths filter for actions.

koebi added a commit that referenced this issue Feb 13, 2024
Using github.event.pull_request and the paths-filter, we can do the same
but shorter.

fixes #1685
koebi added a commit that referenced this issue Feb 13, 2024
Using github.event.pull_request and the paths-filter, we can do the same
but shorter.

fixes #1685
TheGreatRefrigerator pushed a commit that referenced this issue Feb 13, 2024
Using github.event.pull_request and the paths-filter, we can do the same
but shorter.

fixes #1685
TheGreatRefrigerator pushed a commit to TheGreatRefrigerator/openrouteservice that referenced this issue Feb 14, 2024
Using github.event.pull_request and the paths-filter, we can do the same
but shorter.

fixes GIScience#1685
TheGreatRefrigerator added a commit that referenced this issue Feb 14, 2024
Using github.event.pull_request and the paths-filter, we can simplify this

- only run action if config changed
- change workflow to only run job if no draft & open
- rename to synchronization since it's no conversion
- no manual triggering necessary

fixes #1685

Co-authored-by: Amandus <[email protected]>
@MichaelsJP MichaelsJP added this to the V8 Release milestone Mar 7, 2024
selimguvenc pushed a commit to selimguvenc/openrouteservice that referenced this issue Apr 25, 2024
Using github.event.pull_request and the paths-filter, we can simplify this

- only run action if config changed
- change workflow to only run job if no draft & open
- rename to synchronization since it's no conversion
- no manual triggering necessary

fixes GIScience#1685

Co-authored-by: Amandus <[email protected]>
@github-project-automation github-project-automation bot moved this to Awaiting release in ors general Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Awaiting release
Development

Successfully merging a pull request may close this issue.

2 participants