Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type instability in the Polaron type #10

Open
jarvist opened this issue Sep 19, 2019 · 0 comments
Open

Type instability in the Polaron type #10

jarvist opened this issue Sep 19, 2019 · 0 comments
Assignees
@jarvist

Comments

@jarvist
Copy link
Collaborator

jarvist commented Sep 19, 2019

This is very messy, and should be refactored. I think it also ends up as type Any which is not great for efficiency.
https://github.com/jarvist/PolaronMobility.jl/blob/51aa09add590bd6b68406bbf16eb872d2e502a69/src/types.jl#L11-L36
@jarvist jarvist self-assigned this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarvist jarvist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jarvist