Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should SkipExtension be named SkipExtension? #11

Closed
pamil opened this issue Nov 13, 2016 · 2 comments
Closed

Should SkipExtension be named SkipExtension? #11

pamil opened this issue Nov 13, 2016 · 2 comments

Comments

@pamil
Copy link
Member

pamil commented Nov 13, 2016

#9 got me thinking and it looks like "Skip" part in SkipExtension might be misleading, as defined features aren't skipped during testing, but excluded from the test suite.

I propose something like ExcludeExtension, although it is still not as specific as I would like it to be (what about ExcludeFeaturesExtension?).

Should we rename it?

@Zales0123
Copy link
Member

ExcludeFeaturesExtension is not bad, but after adding support for Behat CLI syntax (already working on this) we will be able to skip also specific scenarios, rather than features 😄 So then this name will be misleading... hmm...

Some rabbis say yes, and some rabbis say no

@pamil
Copy link
Member Author

pamil commented Nov 14, 2016

Behat uses the "specification" term, so ExcludeSpecificationsExtension may be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants