Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of legacy scopeManager.resolveReference function #1771

Open
oxisto opened this issue Oct 2, 2024 · 0 comments
Open

Remove usage of legacy scopeManager.resolveReference function #1771

oxisto opened this issue Oct 2, 2024 · 0 comments
Assignees
@oxisto
Labels
core

Comments

@oxisto
Copy link
Member

oxisto commented Oct 2, 2024

The scopeManager.resolveReference function is part of the old symbol resolver and should not be used anymore. However, it is still used in every call of handleReference in the SymbolResolver
@oxisto oxisto self-assigned this Oct 2, 2024
oxisto added a commit that referenced this issue Oct 3, 2024
@oxisto
Cleanup of SymbolResolver
4e7c47b 
Unfortunatly, this cannot really be split into smaller pieces. It basically does the following:
- Move all inference related functions out of the symbol resolve
- Try to restrict / remove calls to the legacy `resolveReference` function

Fixes #1769
Fixes #1771
@oxisto oxisto mentioned this issue Oct 3, 2024
Merged
oxisto added a commit that referenced this issue Oct 3, 2024
@oxisto
Cleanup of SymbolResolver
5523490 
Unfortunatly, this cannot really be split into smaller pieces. It basically does the following:
- Move all inference related functions out of the symbol resolve
- Try to restrict / remove calls to the legacy `resolveReference` function

Fixes #1769
Fixes #1771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxisto oxisto

Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oxisto @konradweiss