Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank square icon appears next to items in combobox on mac #221

Open
aPeter1 opened this issue Aug 18, 2022 · 9 comments
Open

Blank square icon appears next to items in combobox on mac #221

aPeter1 opened this issue Aug 18, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@aPeter1
Copy link
Member

aPeter1 commented Aug 18, 2022

Describe the bug
Checkbox like widget appears next to items when you expand a combobox. This is particularly annoying for small boxes where you can no longer see all the text. Should be an easy fix I imagine, might be a style issue?

@aPeter1 aPeter1 added the bug Something isn't working label Aug 18, 2022
@aPeter1
Copy link
Member Author

aPeter1 commented Aug 18, 2022

This is a known problem which they (QDarkStyle) marked as fixed, I'll have to see how they thought they fixed it because I'm using the newest version and it is still broken. Using older versions of PyQt5, QDarkStyle and Python did not seem to help.

@aPeter1 aPeter1 changed the title Checkbox appears next to items in combobox on mac Blank square icon appears next to items in combobox on mac Aug 18, 2022
@aPeter1
Copy link
Member Author

aPeter1 commented Aug 18, 2022

@jaredblack Do you see the same problem on your mac?

Screen Shot 2022-08-17 at 9 11 52 PM

@jaredblack
Copy link
Collaborator

Screen Shot 2022-08-21 at 9 42 49 PM

I'm seeing that as well. I can't seem to update my dependencies though, so I don't think I'm on that new version of QDarkStyle

@aPeter1
Copy link
Member Author

aPeter1 commented Aug 22, 2022

I'd say we'd probably want to make it so those comboxes aren't a fixed width and then we can see about overriding some style. I kinda doubt they will fix it on their end very soon haha

@aPeter1 aPeter1 modified the milestones: 1.1.0, 1.2.0 Aug 24, 2022
@jaredblack
Copy link
Collaborator

I'm seeing that the comboboxes are the right size now, did you fix that? Should we close the issue now or wait until the QDarkStyle people fix their end?

@aPeter1
Copy link
Member Author

aPeter1 commented Sep 4, 2022

I just expanded the size of the box because I couldn't figure out how to get the size to change appropriately on its own. I'd leave it open as long as the issue exists, maybe we can figure out how to create a style sheet to fix it. We could look at the styles they are applying to the relevant widgets.

@cudmore
Copy link

cudmore commented Oct 27, 2022

@aPeter1, where can I see your changes? I am having the same problem...

@aPeter1
Copy link
Member Author

aPeter1 commented Oct 27, 2022

@cudmore we don't have a great fix for it yet, I just increased the fixed width of the comboboxes by 20. My hopes aren't too high that qdarkstyle will fix it so let us know if you find a good solution!

@alec-petersen
Copy link
Contributor

Someone recommended a fix we can try here. @jaredblack, would you mind checking if it works (just a few lines of code)? I sold my mac 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants