Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements to the chapter view #1317

Open
3 tasks
smadbe opened this issue Mar 6, 2023 · 0 comments
Open
3 tasks

Several improvements to the chapter view #1317

smadbe opened this issue Mar 6, 2023 · 0 comments
Assignees

Comments

@smadbe
Copy link
Contributor

smadbe commented Mar 6, 2023

Overview

Several improvement to the access to the "chapter view".
One of the problem is (as the usual user): go from this group observation page and leave observation -> blank page

Another "problem" is to call that "chapter view" in observation on non chapters.

In my opinion, we should have a single path url which displays something different depending on the case and prevent the blank screen.

4 cases:

  • not observing or observing a single user:
    • on a task: display chapter-user-progress. The selector is named "Chapter view". The selector is only shown if we are on the tab (disappear if we navigate to the history).
    • on a chapter: display chapter-user-progress. The selector is named "Chapter view". The selector is always shown.
  • observing a group
    • on a task: display chapter-group-progress. The selector is named "Grid view". The selector is always shown.
    • on a chapter: display chapter-group-progress. The selector is named "Grid view". The selector is always shown.

Acceptance criteria

  • Have a single url as described
  • Have the right selector title as described
  • Have the selector title disappear in case 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants