Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retries in sensitive steps #283

Open
fall-byrd opened this issue Dec 1, 2024 · 1 comment
Open

Retries in sensitive steps #283

fall-byrd opened this issue Dec 1, 2024 · 1 comment

Comments

@fall-byrd
Copy link
Contributor

I've noticed in a few spots that could be sensitive steps (dispensing reagents for example) we have retries around failure. For certain kinds of failures like hardware communication this could be fine but if it we end up with a partial application of a step with a retry I could see getting into a state that would call for a failure of the full recipe.

This all being said I know we're still getting things fully working so no one should be impacted by this but I wanted to highlight this for consideration well before then.

@phaseloop
Copy link
Contributor

Also retry may actually dispense more than requested for some reason - for example if you miss "ack" from GRBL and it actually ran motors - on retry you will get double the reagent.

Better fail fast than kill someone, so AFAIK we have two options:

  • on any serious error stop the process and that's it
  • on any serious error stop the process and give the user option for example to manually dispense what's needed or left to dispense and hit "Continue".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants