Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio formats / extensions used (make compliant with modern standards) #28

Closed
6 of 7 tasks
osering opened this issue Feb 22, 2024 · 3 comments
Closed
6 of 7 tasks
Labels
template missing The bug/feature template is missing

Comments

@osering
Copy link

osering commented Feb 22, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Right now there is file Extensions (following codec, not indicating container):
(o) m4a
( ) mp3
( ) ogg (Opus)

Problem:

  1. container mp4 with extension m4a can contain 2 codecs: AAC (loose) or ALAC (looseless). ALAC is considered better. Which one is used?
  2. container ogg is very popular and can contain Vorbis, Dirac, Opus and other codecs. How can someone afterwards identify which one is used in this ogg? Specially for this .opus extension has been officially registered (probably in 2018), so the file with opus codec has .opus extension as this is modern and all major operating systems recognize it.

https://wiki.xiph.org/MIME_Types_and_File_Extensions#.opus_-_audio.2Fogg
https://en.m.wikipedia.org/wiki/Opus_(audio_format)#cite_note-MIME-and-FileExt-1
So the codec is Opus, and the container format is Ogg, but the "official" file extension is .opus. 3 different things.

https://en.m.wikipedia.org/wiki/MP4_file_format

Offered change:
( ) m4a (mp4, acc or alac) 128
( ) mp3 128
(o) opus (ogg, opus) 128

Now default choice is m4a. If acc used instead of alac in it, opus could be made as default choice, as it generally performs better than order aac codec.
P.S. Also indicate bitrate (kbps) used for each.

Why do you want this feature?

Make it more clear and standard compliant.

Additional information

No response

@osering osering added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 22, 2024
@Aga-C
Copy link
Member

Aga-C commented Feb 22, 2024

There are multiple requests. Please split it into separate issues.

@Aga-C Aga-C added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Feb 22, 2024
@David-Else
Copy link

In my opinion opus should be the default choice.

https://opus-codec.org/
https://opus-codec.org/release/stable/2023/04/20/libopus-1_4.html
https://developer.android.com/media/platform/supported-formats

Sorry I am not an Android dev, I just know about the amazing high quality of opus.

Copy link

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
@Aga-C Aga-C added invalid This does not seem right and removed feature request Issue is about a new feature in the app waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Mar 24, 2024
@Aga-C Aga-C added template missing The bug/feature template is missing and removed invalid This does not seem right labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template missing The bug/feature template is missing
Projects
None yet
Development

No branches or pull requests

3 participants