Custom settings

[amowry]

I'm trying to override one of the default settings (1-byte parsing):

struct MySettings : public MIDI_NAMESPACE::DefaultSettings
 {
        static const bool Use1ByteParsing = false;  //parse more than 1 byte per MIDI.read()
 };


// Create instances of the Arduino MIDI Library.
MIDI_CREATE_CUSTOM_INSTANCE(BLEMidi, blemidi, BLEMIDI, MySettings);
MIDI_CREATE_CUSTOM_INSTANCE(Adafruit_USBD_MIDI, usb_midi, MIDI, MySettings);


// Create instances of the Arduino MIDI Library.
//MIDI_CREATE_INSTANCE(BLEMidi, blemidi, BLEMIDI);
//MIDI_CREATE_INSTANCE(Adafruit_USBD_MIDI, usb_midi, MIDI);

The default instances (commented out above) work fine, but the custom instances result in errors concerning the baud rate:

In file included from c:\Users\Andrew\Documents\Arduino\libraries\MIDI_Library\src/MIDI.h:35,
                 from C:\Users\Andrew\Documents\GitHub\WARBL2\warbl2_firmware\warbl2_firmware.ino:12:
c:\Users\Andrew\Documents\Arduino\libraries\MIDI_Library\src/serialMIDI.h: In instantiation of 'void midi::SerialMIDI<SerialPort, _Settings>::begin() [with SerialPort = Adafruit_USBD_MIDI; _Settings = MySettings]':
c:\Users\Andrew\Documents\Arduino\libraries\MIDI_Library\src/MIDI.hpp:75:5:   required from 'void midi::MidiInterface<Transport, _Settings, _Platform>::begin(midi::Channel) [with Transport = midi::SerialMIDI<Adafruit_USBD_MIDI, MySettings>; _Settings = midi::DefaultSettings; _Platform = midi::DefaultPlatform; midi::Channel = unsigned char]'
C:\Users\Andrew\Documents\GitHub\WARBL2\warbl2_firmware\warbl2_firmware.ino:596:33:   required from here
c:\Users\Andrew\Documents\Arduino\libraries\MIDI_Library\src/serialMIDI.h:62:13: error: 'BaudRate' is not a member of 'midi::SerialMIDI<Adafruit_USBD_MIDI, MySettings>::Settings' {aka 'MySettings'}
   62 |             mSerial.begin(Settings::BaudRate);
      |             ^~~~~~~
c:\Users\Andrew\Documents\Arduino\libraries\MIDI_Library\src/serialMIDI.h: In instantiation of 'void midi::SerialMIDI<SerialPort, _Settings>::begin() [with SerialPort = BLEMidi; _Settings = MySettings]':
c:\Users\Andrew\Documents\Arduino\libraries\MIDI_Library\src/MIDI.hpp:75:5:   required from 'void midi::MidiInterface<Transport, _Settings, _Platform>::begin(midi::Channel) [with Transport = midi::SerialMIDI<BLEMidi, MySettings>; _Settings = midi::DefaultSettings; _Platform = midi::DefaultPlatform; midi::Channel = unsigned char]'
C:\Users\Andrew\Documents\GitHub\WARBL2\warbl2_firmware\warbl2_firmware.ino:623:36:   required from here
c:\Users\Andrew\Documents\Arduino\libraries\MIDI_Library\src/serialMIDI.h:62:13: error: 'BaudRate' is not a member of 'midi::SerialMIDI<BLEMidi, MySettings>::Settings' {aka 'MySettings'}

Could someone tell me what I'm doing wrong? Thanks!

[amowry]

It looks to me like someone else had the same issue involving baud rate here:

#323

[lathoub]

Baudrate sits in DefaultSerialSettings, Use1ByteParsing is in DefaultSettings - so very different headers

[amongstmyselves]

Similar here. I found putting a baud rate in the custom struct solved the problem BUT the reason I was creating a custom instance was to change the size of the system exclusive buffer. This doesn't work and the buffer remains the same default size of 128 set in midi_settings.h. I confirmed this by changing the SysExMaxSize = 1024 in midi_settings.h.

I'm using Arduino IDE 1.8.5 and the MIDI library version 5.0.2

Do we have a solution to this?

[lathoub]

To resolve your issue, you need the download/fork the latest version from GitHub, not the Release version (that is use in the lib manager from Arduino).

We are working on a new Release (for a while now) that should clear this issue (nudging @franky47).

[franky47]

Yes sorry about the delay, I was refactoring the parser to fix SysEx bugs when my second kid was born, and kind of low on free time now..

[amongstmyselves]

Thanks so much. A really wonderful library by the way. Congratulations on your second child as well.