Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support change log level in settings #2317

Open
rainyl opened this issue Aug 31, 2023 Discussed in #2313 · 10 comments · May be fixed by #2739
Open

Support change log level in settings #2317

rainyl opened this issue Aug 31, 2023 Discussed in #2313 · 10 comments · May be fixed by #2739
Labels
bug Something isn't working

Comments

@rainyl
Copy link
Contributor

rainyl commented Aug 31, 2023

Discussed in #2313

Originally posted by rainyl August 30, 2023
I am one of the Flow plugin developers, I noticed that the default log level of Flow is INFO, I am wondering how to change the log level to DEBUG in Flow, thus I can debug my plugin more efficient using API.LogDebug() and needn't to worry bothering users because their default log level is INFO.

For now, I can't find some settings to change log level, also, if it is currently not supported, I think it will be nice if added.

Thanks.

@jjw24 jjw24 added the bug Something isn't working label Sep 1, 2023
@taooceros
Copy link
Member

If you run flow in debug mode, the debug level will be changed to DEBUG instead of INFO. It shouldn't be a hard thing as you should already have the dotnet sdk installed. All you need is to clone flow and run it with whatever ide you used.

@rainyl
Copy link
Contributor Author

rainyl commented Sep 8, 2023

thanks, but it will be more convenient if we can set it just in settings rather than run another debug version, hope it will be added in the future.

@taooceros
Copy link
Member

thanks, but it will be more convenient if we can set it just in settings rather than run another debug version, hope it will be added in the future.

making sense.

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 24, 2023
@jjw24 jjw24 removed the Stale label Oct 26, 2023
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 11, 2023
@jjw24 jjw24 removed the Stale label Dec 31, 2023
@deefrawley
Copy link
Member

@taooceros is this still an issue we need to keep fresh?

@rainyl
Copy link
Contributor Author

rainyl commented May 18, 2024

Well, fell free to close it if not planed.

@VictoriousRaptor
Copy link
Contributor

It's not that easy to change. Logger is initialized at the very beginning. Maybe we can set to debug for default, after loading settings than set it to user defined level?

@onesounds
Copy link
Contributor

onesounds commented May 20, 2024

Is this a hard task??? It doesn't matter if it doesn't reflect in real time. I think we could just put "loglevel" in config and apply it after restart, or even set it directly in json without a config ui. Am I thinking wrong?

+)#2313 jjw's comment confirms that the debug log itself is meaningless. It is more correct to provide logs to make it easier for plugin developers to work with.

@jjw24
Copy link
Member

jjw24 commented Jul 3, 2024

It's not that easy to change. Logger is initialized at the very beginning. Maybe we can set to debug for default, after loading settings than set it to user defined level?

Set it to 'Error' level as default, allow the change to 'Debug', request a restart of flow after the change if makes it simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

6 participants