Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Support .NET 8.0 plugins #2426

Open
stefanroelofs opened this issue Nov 17, 2023 · 2 comments · May be fixed by #2442
Open

Feature request: Support .NET 8.0 plugins #2426

stefanroelofs opened this issue Nov 17, 2023 · 2 comments · May be fixed by #2442
Labels
enhancement New feature or request keep-fresh

Comments

@stefanroelofs
Copy link

Microsoft just released .NET 8.0.
I upgraded my plugin, but I don't think it is supported yet:

09:26:24.7964+01:00 - ERROR - PluginsLoader.DotNetPlugins - The following plugin has errored and can not be loaded: <BrinkProjectLauncher>
EXCEPTION OCCURS: System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at Type[] System.Reflection.RuntimeAssembly.GetExportedTypes()
   at Type Flow.Launcher.Core.Plugin.PluginAssemblyLoader.FromAssemblyGetTypeOfInterface(Assembly assembly, Type type) in C:/projects/flow-launcher/Flow.Launcher.Core/Plugin/PluginAssemblyLoader.cs:line 40
   at IEnumerable<PluginPair> Flow.Launcher.Core.Plugin.PluginsLoader.DotNetPlugins(List<PluginMetadata> source)+() => { } in C:/projects/flow-launcher/Flow.Launcher.Core/Plugin/PluginsLoader.cs:line 59

No rush of course, just thought I'd let you know.
Thank you!
@stefanroelofs stefanroelofs added the enhancement New feature or request label Nov 17, 2023
@jjw24
Copy link
Member

jjw24 commented Nov 17, 2023 •
edited
Loading

Hi there, thanks for the heads up, that error does look like from .Net support. We probably won't be looking at upgrading to .Net 8 this year, so would be best if your plugin could drop to 7 until we start the upgrade next year.

@taooceros
Copy link
Member

The upgrade should be pretty straightforward. We will take a check on it but I doubt it won't be very soon.

@taooceros taooceros linked a pull request Nov 26, 2023 that will close this issue
Open
@taooceros taooceros mentioned this issue Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request keep-fresh
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update to net8.0 Flow-Launcher/Flow.Launcher
3 participants
@jjw24 @stefanroelofs @taooceros